Page Parent: Change the default value of 'fieldValue' state#76354
Merged
Page Parent: Change the default value of 'fieldValue' state#76354
Conversation
Mamaduka
added
[Type] Bug
|
Size Change: -5 B (0%) Total Size: 6.89 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 447c0e4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22901555105
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
reviewed
Mar 10, 2026
| export function PageAttributesParent() { | ||
| const { editPost } = useDispatch( editorStore ); | ||
| const [ fieldValue, setFieldValue ] = useState( false ); | ||
| const [ fieldValue, setFieldValue ] = useState( '' ); |
Member
There was a problem hiding this comment.
Oh sheez thanks for catching that. LGTM
Member
Author
|
Thanks for testing everyone!
Probably a leftover from a very old component and pattern that got copied. Happens every once in a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #73836.
PR changes the default value of 'fieldValue' state from
null|falseto an empty state. Which fixes the following issue:orderby: 'relevance'is set.It looks like
onFilterValueChangeimmediately updates the state as an empty string when the input is in focus. Since we're dealing with a string, it's better to use an empty string as a default value.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2026-03-10.at.16.00.47.mp4