Skip to content

Feat: Block Library: Improve the design of MediaControlPreview and MediaControl#76430

Merged
t-hamano merged 5 commits intoWordPress:trunkfrom
hbhalodia:feat/issue-75412
Mar 16, 2026
Merged

Feat: Block Library: Improve the design of MediaControlPreview and MediaControl#76430
t-hamano merged 5 commits intoWordPress:trunkfrom
hbhalodia:feat/issue-75412

Conversation

@hbhalodia
Copy link
Copy Markdown
Contributor

What?

Closes #75412

Why?

How?

  • Update the MediaControl and MediaControlPreview component to match style as per BackgroundImageControl in global styles.

Testing Instructions

  1. Open page/post.
  2. Add blocks, Site Logo and Image.
  3. Add image from inspector panel.
  4. See the layout design, with and without image.
  5. It should also have a reset button, visible on hover, focus. Should reset as epxted.
  6. See screencast for more details on testing.

Testing Instructions for Keyboard

  • Just check reset button, should be accessible by keyboard.

Screenshots or screencast

Screen.Recording.2026-03-12.at.2.37.49.PM.mov

@github-actions github-actions bot added [Package] Block library /packages/block-library [Package] Block editor /packages/block-editor labels Mar 12, 2026
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@hbhalodia hbhalodia self-assigned this Mar 12, 2026
@hbhalodia hbhalodia requested a review from t-hamano March 12, 2026 09:12
@im3dabasia im3dabasia added the [Type] Enhancement A suggestion for improvement. label Mar 12, 2026
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

One important point is about the visual text. I think the text should be simple. See #74386 (comment).

Use "Image" instead of "Choose an image…":

Image

Use "Logo" instead of "Choose logo":

Image

@hbhalodia hbhalodia requested a review from t-hamano March 13, 2026 12:16
@hbhalodia hbhalodia requested a review from t-hamano March 13, 2026 14:56
@hbhalodia hbhalodia requested a review from t-hamano March 16, 2026 09:53
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t-hamano t-hamano added the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Mar 16, 2026
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Mar 16, 2026
@t-hamano t-hamano merged commit 91beab3 into WordPress:trunk Mar 16, 2026
46 of 47 checks passed
@github-actions github-actions bot added this to the Gutenberg 22.8 milestone Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Block editor /packages/block-editor [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block Library: Improve the design of MediaControlPreview and MediaControl

3 participants