Remove redundant onNavigateToEntityRecord handling#76523
Merged
youknowriad merged 1 commit intotrunkfrom Mar 16, 2026
Merged
Conversation
The filter excluding onNavigateToEntityRecord from the spread and the explicit re-assignment are no longer needed. After PR #75371 removed the wrapping logic, onNavigateToEntityRecord now passes through directly. Since it's in the BLOCK_EDITOR_SETTINGS allowlist, it's already included via the Object.fromEntries spread. Co-Authored-By: Claude Haiku 4.5 <[email protected]>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
added
the
[Type] Code Quality
|
Size Change: -10 B (0%) Total Size: 8.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cf27c54. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23134642126
|
ellatrix
reviewed
Mar 16, 2026
| hasFixedToolbar, | ||
| isDistractionFree, | ||
| keepCaretInsideBlock, | ||
| onNavigateToEntityRecord: settings.onNavigateToEntityRecord, |
Member
There was a problem hiding this comment.
Should it be removed from the dependencies too?
Member
There was a problem hiding this comment.
I think so, the linter was complaining about the deps in this hook.
Contributor
Author
There was a problem hiding this comment.
I don't think it should be removed from the dependencies as otherwise the settings won't update when it changes.
ellatrix
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the now-unnecessary filter and explicit re-assignment of
onNavigateToEntityRecordfromuseBlockEditorSettings. Addresses #75371 (comment)Why?
After PR #75371 removed the wrapping logic for
onNavigateToEntityRecord, the setting now passes through directly. SinceonNavigateToEntityRecordis already in theBLOCK_EDITOR_SETTINGSallowlist, the filter excluding it and the explicit re-assignment are redundant.How?
Removed the
.filter( ( [ key ] ) => key !== 'onNavigateToEntityRecord' )and its comment, along with the explicitonNavigateToEntityRecord: settings.onNavigateToEntityRecordassignment. The setting is now handled purely through theObject.fromEntriesspread of allowed keys.