E2E Tests: Enable client-side media processing for site editor image test#76648
Merged
adamsilverstein merged 1 commit intotrunkfrom Mar 30, 2026
Merged
Conversation
…test Remove the `gutenberg-test-plugin-disable-client-side-media-processing` workaround from the "Image - Site editor" test. The upload pipeline issue that originally required this workaround (items getting stuck in the upload-media store queue) has been resolved by subsequent improvements to the upload pipeline. The test now runs with client-side media processing enabled and passes reliably, matching the behavior of the post editor image tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
adamsilverstein
added
[Type] Automated Testing
8 tasks
|
Size Change: 0 B Total Size: 8.76 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 36ee5b8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23265526994
|
andrewserong
approved these changes
Mar 19, 2026
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
LGTM, e2es are passing locally and in the Github Actions 
| await expect( image ).toHaveAttribute( 'src', /\/[^\s]+\.\w+$/i, { | ||
| // Wait for upload to complete (includes client-side media processing time). | ||
| // With client-side processing, the filename may be changed by the server. | ||
| await expect( image ).toHaveAttribute( 'src', /^https?:\/\//, { |
Contributor
There was a problem hiding this comment.
This change looks good to me, I assume all we're really wanting to test is that we have a real url now instead of a blob 👍
adamsilverstein
deleted the
fix/site-editor-client-media-processing-test
branch
adamsilverstein
added a commit
that referenced
this pull request
Mar 31, 2026
…test (#76648) Remove the `gutenberg-test-plugin-disable-client-side-media-processing` workaround from the "Image - Site editor" test. The upload pipeline issue that originally required this workaround (items getting stuck in the upload-media store queue) has been resolved by subsequent improvements to the upload pipeline. The test now runs with client-side media processing enabled and passes reliably, matching the behavior of the post editor image tests. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ObliviousHarmony
pushed a commit
that referenced
this pull request
Apr 1, 2026
…test (#76648) Remove the `gutenberg-test-plugin-disable-client-side-media-processing` workaround from the "Image - Site editor" test. The upload pipeline issue that originally required this workaround (items getting stuck in the upload-media store queue) has been resolved by subsequent improvements to the upload pipeline. The test now runs with client-side media processing enabled and passes reliably, matching the behavior of the post editor image tests. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
adamsilverstein
added a commit
that referenced
this pull request
Apr 7, 2026
…test (#76648) Remove the `gutenberg-test-plugin-disable-client-side-media-processing` workaround from the "Image - Site editor" test. The upload pipeline issue that originally required this workaround (items getting stuck in the upload-media store queue) has been resolved by subsequent improvements to the upload pipeline. The test now runs with client-side media processing enabled and passes reliably, matching the behavior of the post editor image tests. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gutenberg-test-plugin-disable-client-side-media-processingworkaround from the "Image - Site editor" E2E testcore/upload-mediastore queue) has been resolved by subsequent improvements to the upload pipeline--repeat-each=3)Contributes to #74367
Test plan
npm run test:e2e -- test/e2e/specs/editor/blocks/image.spec.js --grep "Site editor"— should passnpm run test:e2e -- test/e2e/specs/editor/blocks/image.spec.js— all 23 image block tests should pass--repeat-each=3🤖 Generated with Claude Code