Merged
Conversation
sgomes
added
[Feature] Client Side Media
swissspidy
approved these changes
Mar 24, 2026
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Note that I'm not entirely sure what the positive impact of this fix might be. Performance-wise, I couldn't measure much of an uplift, but it may solve some of the existing issues around memory usage and resulting crashes. |
|
Size Change: 0 B Total Size: 7.66 MB ℹ️ View Unchanged
|
4 tasks
|
Flaky tests detected in fae657a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23489557643
|
andrewserong
approved these changes
Mar 28, 2026
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
This looks like a good improvement to me, too, and it's testing well for me manually 👍
Contributor
Author
|
Thank you for taking a look, @swissspidy and @andrewserong! 👍 |
adamsilverstein
pushed a commit
that referenced
this pull request
Mar 31, 2026
Co-authored-by: sgomes <sergiomdgomes@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
oandregal
added
[Type] Bug
ObliviousHarmony
pushed a commit
that referenced
this pull request
Apr 1, 2026
Co-authored-by: sgomes <sergiomdgomes@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
6 tasks
Member
|
Thanks for this @sgomes! |
adamsilverstein
added a commit
that referenced
this pull request
Apr 2, 2026
Fix unintended revert of #76780 during rebase. The promise-based approach ensures only a single Vips instance is ever created, even when multiple callers race on initialization.
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
Co-authored-by: sgomes <sergiomdgomes@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
adamsilverstein
added a commit
that referenced
this pull request
Apr 12, 2026
* Use image.copyMemory() for batch thumbnail generation Decode the source image once via copyMemory() and use thumbnailImage() for each sub-size, instead of re-decoding the source buffer for every thumbnail. This approach was suggested by the wasm-vips maintainer and avoids both re-decoding overhead and the need for intermediate format conversions. The new batchResizeImage() function in the vips package materializes the decoded image in WASM memory, then generates all thumbnails from that single in-memory copy. Results are written directly to the target output format, eliminating separate transcode steps. Falls back to per-thumbnail processing if the batch operation fails. * Restore vipsPromise singleton pattern in getVips() Fix unintended revert of #76780 during rebase. The promise-based approach ensures only a single Vips instance is ever created, even when multiple callers race on initialization. * Extract shared resize/crop logic into common helpers Add applyResizeAndCrop() to consolidate the duplicated dimension calculation and crop logic between resizeImage and batchResizeImage. Add buildSaveOptions() to unify save option construction, which also fixes the missing AVIF effort=2 setting in resizeImage. * Address review nits in applyResizeAndCrop and batchResizeImage Clone the resize config into a local target object rather than mutating the caller's ImageSizeCrop parameter, and drop an unused strOptions constant in batchResizeImage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR ensures that a single instance of
vipsgets created, by caching a promise instead of a fully initialised instance.Why?
The existing code has a race condition where successive calls to
getVips()can end up creating multiple instances. SincegetVipsis async, if a new call is made before the instance initialisation is complete, it will create a new instance.How?
This PR changes the cache to a promise instead of an instance. This way, the promise is immediately set the first time
getVips()is called, and subsequent calls will wait for the same promise, instead of creating their own.Testing Instructions
npm run test:unit -- packages/upload-mediapassesnpm run test:unit -- packages/vipspassesUse of AI Tools
No AI tools were used.