Reduce specificity of nav link default padding so global styles apply#76876
Merged
tellthemachines merged 1 commit intotrunkfrom Mar 28, 2026
Merged
Reduce specificity of nav link default padding so global styles apply#76876tellthemachines merged 1 commit intotrunkfrom
tellthemachines merged 1 commit intotrunkfrom
Conversation
tellthemachines
added
[Type] Bug
|
Size Change: +61 B (0%) Total Size: 7.73 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b32c80b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23676288704
|
MaggieCabrera
approved these changes
Mar 28, 2026
Contributor
MaggieCabrera
left a comment
MaggieCabrera
left a comment
There was a problem hiding this comment.
The change looks sensible and it tests well. We should revisit the UI for this block to support these controls in another PR (self reminder here kinda)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jeghebe. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Could this fix be backported to WP 7.0 Beta/RC? |
Contributor
Author
At this point in the release only fixes for regressions from 6.9 should be merged, and I believe this issue has been around for longer than that. |
adamsilverstein
pushed a commit
that referenced
this pull request
Mar 31, 2026
…pplied (#76876) Unlinked contributors: jeghebe. Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: mrleemon <leemon@git.wordpress.org> Co-authored-by: prasadkarmalkar <prasadkarmalkar@git.wordpress.org> Co-authored-by: 3kori <r1k0@git.wordpress.org>
ObliviousHarmony
pushed a commit
that referenced
this pull request
Apr 1, 2026
…pplied (#76876) Unlinked contributors: jeghebe. Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: mrleemon <leemon@git.wordpress.org> Co-authored-by: prasadkarmalkar <prasadkarmalkar@git.wordpress.org> Co-authored-by: 3kori <r1k0@git.wordpress.org>
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
…pplied (#76876) Unlinked contributors: jeghebe. Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: mrleemon <leemon@git.wordpress.org> Co-authored-by: prasadkarmalkar <prasadkarmalkar@git.wordpress.org> Co-authored-by: 3kori <r1k0@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #76306
Default padding added in block library for Navigation Link has higher specificity than global styles, so these don't work.
It was originally added with that specificity to override generic list padding styles that themes might add under
.entry-content li(see here for context). I had a quick look in Veloria and couldn't find any of those, which doesn't mean they don't exist, but it's not super likely themes will add a padding reset tolibecause user agents don't add padding to that element.I guess we could remove it altogether, but in case anyone out there is relying on it this PR just lowers the rule specificity enough that it doesn't interfere with global styles.
Testing Instructions