DataForm: support a compact version for the datetime control#76905
Merged
ntsekouras merged 2 commits intotrunkfrom Mar 31, 2026
Merged
DataForm: support a compact version for the datetime control#76905ntsekouras merged 2 commits intotrunkfrom
datetime control#76905ntsekouras merged 2 commits intotrunkfrom
Conversation
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
[Package] Editor
ntsekouras
commented
Mar 30, 2026
| } | ||
| } | ||
|
|
||
| .fields-controls__password { |
Contributor
Author
There was a problem hiding this comment.
These are the same styles we have for site editor.
Member
There was a problem hiding this comment.
shouldn't these be part of the password field?
Contributor
Author
There was a problem hiding this comment.
I'm not sure because even if the password field right now is rendered as a child field of status, are we committing to the concept of this field always being a part of status. If yes, we can move them there.
If not, the field shouldn't have such specific styles.
Is this something though that highlights the need for nested fields to support some different styles (like borders)? Same case applies to the scheduled date, which is also part of status, but right now has no border separator.
Member
There was a problem hiding this comment.
I see. So these styles are unrelated to the scheduled datetime control, but rather to replicate this:
Separators between fields should be absorbed by the layout config, and there's some conversation about that at #75916.
In the meantime, it's not clear how to deal with this but they are more "form styles" than they are "field styles". Can we scope them to the sidebar experiment and link to this conversation/the field groups issue as a TODO stating it should be replaced with form config?
|
Size Change: +280 B (0%) Total Size: 7.73 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8770db6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23785977030
|
oandregal
approved these changes
Mar 30, 2026
ntsekouras
force-pushed
the
add-compact-config-datetime-df-control
branch
from
fdc00d8 to
8770db6
Compare
ObliviousHarmony
pushed a commit
that referenced
this pull request
Apr 1, 2026
#76905) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
#76905) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org>
oandregal
changed the title
compact configuration option to the datetime controldatetime control
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #76234
This PR adds
compactconfig to DataForms datetime control. This is used inscheduled_datefield for now which is conditionally rendered as a child of the post status field.Testing Instructions
quick editof a page, edit thestatusand selectscheduled. The rendered control should display only theinputEditor Inspector: Use DataFormexperiment enabled.?path=/story/dataviews-fieldtypes--date-time-componentTesting Instructions for Keyboard
Screenshots or screencast