Load migration script in plugin setting page#920
Merged
felixarntz merged 2 commits intofeature/creating-standalone-pluginsfrom Jan 8, 2024
Merged
Conversation
This was referenced Jan 5, 2024
swissspidy
approved these changes
Jan 5, 2024
Member
|
Thanks @mukeshpanchal27, good catch! Regarding the fix though, I think there would be a cleaner solution:
|
Member
Author
|
Thank you for the feedback! In the commit abc39aa, I've incorporated the new JS as per your suggestion and relocated both JS file into a designated |
swissspidy
approved these changes
Jan 8, 2024
felixarntz
approved these changes
Jan 8, 2024
Member
felixarntz
left a comment
There was a problem hiding this comment.
This looks great, thank you @mukeshpanchal27!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #899, we incorporated logic to load the migration script only when any module activated with the associated standalone plugins.
However, in #900, we further enhanced the experience when installing and activating standalone plugins. There's a need to ensure that this enhancement still functions properly if a module is deactivated and someone tries to install and activate the standalone plugins from the settings page.
To replicate the issue:
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.