Sd card usb presentation fixes#10645
Merged
dhalbert merged 5 commits intoadafruit:mainfrom Sep 26, 2025
Merged
Conversation
tannewt
requested changes
Sep 25, 2025
Member
tannewt
left a comment
There was a problem hiding this comment.
Minor things. Want to document this behavior somewhere? Maybe the workflow markdown?
185841e to
d5ca685
Compare
Collaborator
Author
I added a paragraph to the |
db41daf to
edd4532
Compare
This was referenced Oct 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SD card USB presentation
.h-only compile optionCIRCUITPY_SDCARD_USB, which will enable/disable presenting SD card as a USB MSC LUN.atmel-samddue to some bug that causes USB disconnection. I tested most of the other ports, and they don't have this problem. I'll open a separate issue about this for fixing post 10.0.0.Prevent unneeded auto-reload
Technical debt found in passing
gc_ptr_on_heap()instead ofgc_nbytes() > 0when checking if an object on the heap. Will be slightly faster.supervisor/shared/usb/usb_msc_flash.cso the editor does not mess up the indentation.