Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Cherrypick Fix nightly large_vector test caused by incorrect with_seed path (#18178)#18220

Merged
leezu merged 2 commits intoapache:v1.7.xfrom
ChaiBapchya:cp_nightly_fix
May 4, 2020
Merged

Cherrypick Fix nightly large_vector test caused by incorrect with_seed path (#18178)#18220
leezu merged 2 commits intoapache:v1.7.xfrom
ChaiBapchya:cp_nightly_fix

Conversation

@ChaiBapchya
Copy link
Copy Markdown
Contributor

@ChaiBapchya ChaiBapchya commented May 1, 2020

@ciyongch @leezu
This unblocks the v1.7.x nightly test for binaries pipeline.

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 1, 2020

Hey @ChaiBapchya , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, edge, centos-gpu, unix-cpu, centos-cpu, windows-gpu, website, sanity, clang, unix-gpu, windows-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ChaiBapchya ChaiBapchya mentioned this pull request May 1, 2020
Merged
3 tasks
@ChaiBapchya
Copy link
Copy Markdown
Contributor Author

ChaiBapchya commented May 3, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 3, 2020

Jenkins CI successfully triggered : [unix-gpu]

@ChaiBapchya
Copy link
Copy Markdown
Contributor Author

ChaiBapchya commented May 3, 2020

Hangs after np_empty. Known issue.
Retriggering @mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 3, 2020

Jenkins CI successfully triggered : [unix-gpu]

@ChaiBapchya
Copy link
Copy Markdown
Contributor Author

ChaiBapchya commented May 4, 2020

Yet another hang at np empty test.
@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 4, 2020

Jenkins CI successfully triggered : [unix-gpu]

@ChaiBapchya
Copy link
Copy Markdown
Contributor Author

ChaiBapchya commented May 4, 2020

@mxnet-label-bot add [pr-awaiting-merge, pr-awaiting-review]

@lanking520 lanking520 added pr-awaiting-merge Review and CI is complete. Ready to Merge pr-awaiting-review PR is waiting for code review labels May 4, 2020
@leezu leezu merged commit 295e939 into apache:v1.7.x May 4, 2020
This was referenced May 10, 2020
Closed
Merged
ChaiBapchya added a commit to ChaiBapchya/mxnet that referenced this pull request May 10, 2020
@ChaiBapchya
Fix pylint astroid sanity issue
0a90248 
Cherrypick apache@18e2014 from apache#18220
@ChaiBapchya ChaiBapchya mentioned this pull request May 10, 2020
Merged
leezu pushed a commit that referenced this pull request May 11, 2020
@ChaiBapchya
Fix pylint astroid sanity issue (#18275)
38ec873 
* Fix pylint astroid sanity issue

Cherrypick 18e2014 from #18220
ChaiBapchya added a commit to ChaiBapchya/mxnet that referenced this pull request Aug 15, 2020
@ChaiBapchya
Fix pylint astroid sanity issue (apache#18275)
4b9bb1a 
* Fix pylint astroid sanity issue

Cherrypick apache@18e2014 from apache#18220
@samskalicky
Copy link
Copy Markdown
Contributor

samskalicky commented Sep 18, 2020

@ChaiBapchya any reason this wasnt committed to 1.x branch?

@ChaiBapchya
Copy link
Copy Markdown
Contributor Author

ChaiBapchya commented Sep 20, 2020

Missed it. Thanks for catching.

@ChaiBapchya ChaiBapchya mentioned this pull request Sep 20, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees

No one assigned

Labels

pr-awaiting-merge Review and CI is complete. Ready to Merge pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ChaiBapchya @mxnet-bot @samskalicky @leezu @lanking520