Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] ONNX support for box_decode#19750

Merged
Zha0q1 merged 2 commits intoapache:v1.xfrom
waytrue17:box_decode
Jan 15, 2021
Merged

[v1.x] ONNX support for box_decode#19750
Zha0q1 merged 2 commits intoapache:v1.xfrom
waytrue17:box_decode

Conversation

@waytrue17
Copy link
Copy Markdown
Contributor

@waytrue17 waytrue17 commented Jan 13, 2021

Description

ONNX support for box_decode

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@waytrue17 waytrue17 requested a review from szha as a code owner January 13, 2021 20:26
@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Jan 13, 2021

Hey @waytrue17 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, centos-cpu, windows-gpu, sanity, unix-gpu, website, edge, miscellaneous, clang, unix-cpu, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jan 13, 2021
Zha0q1
Zha0q1 approved these changes Jan 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 13, 2021
@waytrue17
Copy link
Copy Markdown
Contributor Author

waytrue17 commented Jan 13, 2021

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Jan 13, 2021

Jenkins CI successfully triggered : [unix-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 13, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-merge Review and CI is complete. Ready to Merge pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jan 14, 2021
josephevans
josephevans approved these changes Jan 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 14, 2021
@waytrue17
Copy link
Copy Markdown
Contributor Author

waytrue17 commented Jan 14, 2021

@mxnet-bot run ci [website]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Jan 14, 2021

Jenkins CI successfully triggered : [website]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jan 14, 2021
@waytrue17
Copy link
Copy Markdown
Contributor Author

waytrue17 commented Jan 14, 2021

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Jan 14, 2021

Jenkins CI successfully triggered : [unix-gpu]

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 14, 2021
@waytrue17
Copy link
Copy Markdown
Contributor Author

waytrue17 commented Jan 14, 2021 •
edited
Loading

@mxnet-bot run ci [unix-gpu, website]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Jan 14, 2021

Jenkins CI successfully triggered : [website, unix-gpu]

@waytrue17
Copy link
Copy Markdown
Contributor Author

waytrue17 commented Jan 15, 2021 •
edited
Loading

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Jan 15, 2021

Jenkins CI successfully triggered : [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Jan 15, 2021

Jenkins CI successfully triggered : [unix-gpu, website]

1 similar comment
@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Jan 15, 2021

Jenkins CI successfully triggered : [unix-gpu, website]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 15, 2021
Zha0q1
Zha0q1 approved these changes Jan 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Zha0q1 Zha0q1 merged commit d6abe00 into apache:v1.x Jan 15, 2021
@waytrue17 waytrue17 deleted the box_decode branch January 15, 2021 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

2 more reviewers

@josephevans josephevans josephevans approved these changes

@Zha0q1 Zha0q1 Zha0q1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@waytrue17 @mxnet-bot @josephevans @Zha0q1 @lanking520