This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[BACKPORT]Add option to build with shared c runtime on windows (#19409)#19932
Merged
szha merged 1 commit intoapache:v1.xfrom Feb 23, 2021
Merged
[BACKPORT]Add option to build with shared c runtime on windows (#19409)#19932szha merged 1 commit intoapache:v1.xfrom
szha merged 1 commit intoapache:v1.xfrom
Conversation
Co-authored-by: vlado <vlado@indicalab.com>
|
Hey @access2rohit , Thanks for submitting the PR
CI supported jobs: [miscellaneous, windows-cpu, centos-gpu, website, unix-gpu, windows-gpu, edge, unix-cpu, centos-cpu, clang, sanity] Note: |
lanking520
added
the
pr-awaiting-testing
Contributor
Author
|
@vladoovtcharov @szha can you review ? |
lanking520
added
pr-work-in-progress
Contributor
Author
|
@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu, windows-cpu] |
|
Jenkins CI successfully triggered : [unix-cpu, unix-gpu, windows-cpu, centos-gpu] |
lanking520
added
pr-awaiting-testing
Contributor
Author
|
@yajiedesign please review |
lanking520
added
pr-awaiting-review
Contributor
|
I'm not a reviewer, but looks like the commit got backported correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: vlado vlado@indicalab.com
Backport #19409 as a part of effort #19911