This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Fix precision vars initialization in TRT#20277
Merged
DickJC123 merged 1 commit intoapache:v1.xfrom May 20, 2021
Merged
Conversation
Signed-off-by: Serge Panev <spanev@nvidia.com>
|
Hey @Kh4L , Thanks for submitting the PR
CI supported jobs: [clang, centos-gpu, unix-cpu, centos-cpu, miscellaneous, unix-gpu, windows-cpu, windows-gpu, edge, website, sanity] Note: |
mseth10
added
pr-awaiting-testing
DickJC123
approved these changes
May 20, 2021
Contributor
DickJC123
left a comment
DickJC123
left a comment
There was a problem hiding this comment.
Yes, one needs to remember that data members like fp16_mode_ and int8_mode_ are not initialized by default. I see that calibration_iters_ is initted only when needed (i.e. when int8_mode_ is true). LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix precision vars initialization in TRT