Skip to content

mesa-vpu: don't install mesa-vpu on minimal images#7331

Merged
igorpecovnik merged 1 commit intomainfrom
fix-mesa
Oct 4, 2024
Merged

mesa-vpu: don't install mesa-vpu on minimal images#7331
igorpecovnik merged 1 commit intomainfrom
fix-mesa

Conversation

@igorpecovnik
Copy link
Copy Markdown
Member

@igorpecovnik igorpecovnik commented Oct 3, 2024

Description

Keeping minimal images as minimal as possible. Addition to:
#7318

How Has This Been Tested?

CI throws error when trying to add PPA:add-apt-repository: command not found We don't (want) to have software-properties-common package and dependencies on minimal images.

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the size/small PR with less then 50 lines label Oct 3, 2024
@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Needs review Seeking for review and removed size/small PR with less then 50 lines labels Oct 3, 2024
@github-actions github-actions bot added the Framework Framework components label Oct 3, 2024
@EvilOlaf
Copy link
Copy Markdown
Member

EvilOlaf commented Oct 3, 2024

Not sure if doing this "silently" is the right approach. What's the reason not to add a hint mesa-vpu is not being installed when minimal is selected? and what to do if users want it anyways for wahtever reason?

@github-actions github-actions bot added the size/small PR with less then 50 lines label Oct 3, 2024
@igorpecovnik
Copy link
Copy Markdown
Member Author

Added warning instead.

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Oct 3, 2024
@igorpecovnik
Copy link
Copy Markdown
Member Author

CI breaks without this. Different way can be done later if desired.

@igorpecovnik igorpecovnik merged commit 9895cbe into main Oct 4, 2024
@igorpecovnik igorpecovnik deleted the fix-mesa branch October 4, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

3 participants