Skip to content

document DOCKER_NICE hidden parameter for compile.sh#815

Merged
igorpecovnik merged 1 commit intoarmbian:mainfrom
tabrisnet:tabrisnet_8353_renice-docker
Sep 7, 2025
Merged

document DOCKER_NICE hidden parameter for compile.sh#815
igorpecovnik merged 1 commit intoarmbian:mainfrom
tabrisnet:tabrisnet_8353_renice-docker

Conversation

@tabrisnet
Copy link
Copy Markdown
Collaborator

document DOCKER_NICE hidden parameter for compile.sh
See armbian/build#8353 for motivation and armbian/build#8582 for implementation

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Sep 6, 2025

Walkthrough

Adds a new documentation bullet for DOCKER_NICE in docs/Developer-Guide_Build-Switches.md. The entry defines DOCKER_NICE as an integer in the range -20 to 19, noting it is propagated from the initial compile.sh nice value for Docker builds. No code, behavior, or public API changes. The item is appended after DISABLE_KERNEL_PATCHES.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

Needs review, size/small

Suggested reviewers

  • igorpecovnik
  • EvilOlaf
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review and removed size/small PR with less then 50 lines labels Sep 6, 2025
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
docs/Developer-Guide_Build-Switches.md (2)

392-392: Tighten grammar and clarify scope/constraints.
Current phrasing is awkward; also note privilege constraint for negative niceness.

Apply this diff:

-- **DOCKER_NICE** ( `integer`, -20 to 19 ): automatically propagated from the initial `compile.sh`'s `nice` value.
+- **DOCKER_NICE** ( `integer`, -20 to 19 ): propagated from the nice level used to invoke `compile.sh` for Docker builds; negative values may require CAP_SYS_NICE (i.e., a privileged container).

392-392: Consistency nit: range formatting.
Elsewhere ranges use spaced hyphens (e.g., “1 - 9”). Consider “-20 - 19” or standardize all ranges in this doc.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7a0a745 and 1edb2d3.

📒 Files selected for processing (1)
  • docs/Developer-Guide_Build-Switches.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/Developer-Guide_Build-Switches.md

[grammar] ~392-~392: There might be a mistake here.
Context: ...the initial compile.sh's nice value.

(QB_NEW_EN)

🔇 Additional comments (1)
docs/Developer-Guide_Build-Switches.md (1)

392-392: Good addition; helpful to surface this hidden switch.
Placement under “Hidden options for advanced users” is appropriate.

@igorpecovnik igorpecovnik merged commit db96f71 into armbian:main Sep 7, 2025
1 check passed
@tabrisnet tabrisnet deleted the tabrisnet_8353_renice-docker branch September 7, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs review Seeking for review

Development

Successfully merging this pull request may close these issues.

2 participants