document DOCKER_NICE hidden parameter for compile.sh#815
document DOCKER_NICE hidden parameter for compile.sh#815igorpecovnik merged 1 commit intoarmbian:mainfrom
Conversation
WalkthroughAdds a new documentation bullet for DOCKER_NICE in docs/Developer-Guide_Build-Switches.md. The entry defines DOCKER_NICE as an integer in the range -20 to 19, noting it is propagated from the initial compile.sh nice value for Docker builds. No code, behavior, or public API changes. The item is appended after DISABLE_KERNEL_PATCHES. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/Developer-Guide_Build-Switches.md (2)
392-392: Tighten grammar and clarify scope/constraints.
Current phrasing is awkward; also note privilege constraint for negative niceness.Apply this diff:
-- **DOCKER_NICE** ( `integer`, -20 to 19 ): automatically propagated from the initial `compile.sh`'s `nice` value. +- **DOCKER_NICE** ( `integer`, -20 to 19 ): propagated from the nice level used to invoke `compile.sh` for Docker builds; negative values may require CAP_SYS_NICE (i.e., a privileged container).
392-392: Consistency nit: range formatting.
Elsewhere ranges use spaced hyphens (e.g., “1 - 9”). Consider “-20 - 19” or standardize all ranges in this doc.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/Developer-Guide_Build-Switches.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/Developer-Guide_Build-Switches.md
[grammar] ~392-~392: There might be a mistake here.
Context: ...the initial compile.sh's nice value.
(QB_NEW_EN)
🔇 Additional comments (1)
docs/Developer-Guide_Build-Switches.md (1)
392-392: Good addition; helpful to surface this hidden switch.
Placement under “Hidden options for advanced users” is appropriate.
document
DOCKER_NICEhidden parameter forcompile.shSee armbian/build#8353 for motivation and armbian/build#8582 for implementation