Update the documentation around opting out of an individual hook function#864
Update the documentation around opting out of an individual hook function#864tabrisnet merged 1 commit intoarmbian:mainfrom
Conversation
WalkthroughThis pull request updates Developer Guide Extensions documentation to change the recommended opt-out method for individual hook functions. The prior example using Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/Developer-Guide_Extensions.md (1)
109-118: Fix grammatical awkwardness on line 117.The documentation properly documents the new
extension_hook_opt_outfunction as the mechanism for skipping extension hook functions, replacing the previousunset -fapproach. The additional guidance about copying and modifying functions adds useful context.One grammatical issue: Line 117 repeats "doing so" which reads awkwardly. Reword to: "Doing so is at the board/family maintainer's own risk and is officially unsupported."
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/Developer-Guide_Extensions.md
19bae9f to
fd8549a
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/Developer-Guide_Extensions.md (1)
117-118: Minor: Reduce repetition in advisory text.The phrase "doing so" is used twice in line 117 ("Doing so is at the board/family maintainer's own risk and doing so is officially unsupported"), which is slightly redundant. Consider consolidating for tighter prose:
✍️ Suggested wording refinement
-Doing so is at the board/family maintainer's own risk and doing so is officially unsupported. Consider splitting the function into pieces so that only the part the board/family cannot tolerate is skipped. +This is at the board/family maintainer's own risk and is officially unsupported. Consider splitting the function into pieces so that only the part the board/family cannot tolerate is skipped.The added advisory on line 118 about copying and modifying the function is helpful and provides practical flexibility while maintaining the recommendation for function splitting.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
docs/Developer-Guide_Extensions-Hooks.mddocs/Developer-Guide_Extensions.md
✅ Files skipped from review due to trivial changes (1)
- docs/Developer-Guide_Extensions-Hooks.md
🔇 Additional comments (1)
docs/Developer-Guide_Extensions.md (1)
109-115: Clear explanation of the new opt-out mechanism.The documentation correctly replaces the deprecated
unset -fapproach with the newextension_hook_opt_outfunction. The syntax is properly formatted with appropriate quoting, and the context makes it easy for users to understand when and how to use this mechanism.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/Developer-Guide_Extensions.md (1)
109-118: Documentation update is clear and well-structured.The change properly implements the new recommended approach using
extension_hook_opt_outand includes appropriate risk warnings and alternatives. The section is well-positioned for users seeking this information.Minor suggestion: On line 118, consider removing the hyphen from "intolerable-function" to match the phrasing on line 117 ("the part the board/family cannot tolerate"). This small adjustment would improve consistency in terminology throughout the advisory.
Minor consistency improvement (optional)
- You can also opt out, then copy the otherwise-intolerable function into your own config and modify it as appropriate. Splitting the intolerable-function is still highly recommended. + You can also opt out, then copy the otherwise-intolerable function into your own config and modify it as appropriate. Splitting the intolerable function is still highly recommended.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/Developer-Guide_Extensions.md
e916be6 to
7665ee0
Compare
update from #842 in re armbian/build#9178.
basically we no longer use
unset -fdirectly, but instead useextension_hook_opt_out