feat: add Windows code signing with SignPath#76
Merged
Conversation
- Integrate SignPath.io for Windows artifact signing (MSI, NSIS) - Add sign-windows job to release workflow - Upload unsigned artifacts as temporary GitHub artifacts - Sign artifacts via SignPath API before release upload - Rename workflows: build.yml -> release.yml, build-artifacts.yml -> build.yml - Update DEVELOPMENT.md with new workflow structure - Add SignPath acknowledgment to README.md
SuperKali
added a commit
that referenced
this pull request
Jan 12, 2026
- Integrate SignPath.io for Windows artifact signing (MSI, NSIS) - Add sign-windows job to release workflow - Upload unsigned artifacts as temporary GitHub artifacts - Sign artifacts via SignPath API before release upload - Rename workflows: build.yml -> release.yml, build-artifacts.yml -> build.yml - Update DEVELOPMENT.md with new workflow structure - Add SignPath acknowledgment to README.md
SuperKali
added a commit
that referenced
this pull request
Jan 12, 2026
- Integrate SignPath.io for Windows artifact signing (MSI, NSIS) - Add sign-windows job to release workflow - Upload unsigned artifacts as temporary GitHub artifacts - Sign artifacts via SignPath API before release upload - Rename workflows: build.yml -> release.yml, build-artifacts.yml -> build.yml - Update DEVELOPMENT.md with new workflow structure - Add SignPath acknowledgment to README.md
SuperKali
added a commit
that referenced
this pull request
Jan 12, 2026
- Integrate SignPath.io for Windows artifact signing (MSI, NSIS) - Add sign-windows job to release workflow - Upload unsigned artifacts as temporary GitHub artifacts - Sign artifacts via SignPath API before release upload - Rename workflows: build.yml -> release.yml, build-artifacts.yml -> build.yml - Update DEVELOPMENT.md with new workflow structure - Add SignPath acknowledgment to README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR integrates SignPath.io for Windows code signing, ensuring all Windows releases (MSI and NSIS installers) are cryptographically signed with a trusted certificate.
Changes
Workflow restructure:
build.yml→release.yml(production releases with signing)build-artifacts.yml→build.yml(development/test builds)SignPath integration (
release.yml):sign-windowsjob submits artifacts to SignPath for signing.exe.sig) are uploaded directly (not affected by Windows code signing)Documentation:
DEVELOPMENT.mdwith new workflow structureNew workflow flow
build-windows-x64build-windows-arm64sign-windowssign-windowsTesting
This PR uses the
test-signingpolicy with a test certificate. Once verified working, SignPath will provision the production release certificate.References