Skip to content

arm64: dts: DTS for Luckfox Core3566#254

Merged
SuperKali merged 4 commits intoarmbian:rk-6.1-rkr3from
buldo:core3566
Oct 8, 2024
Merged

arm64: dts: DTS for Luckfox Core3566#254
SuperKali merged 4 commits intoarmbian:rk-6.1-rkr3from
buldo:core3566

Conversation

@buldo
Copy link
Copy Markdown
Contributor

@buldo buldo commented Oct 2, 2024

Device tree files from vendor SDK
Link to SDK https://drive.google.com/drive/folders/1q8zXpt3WzSfGyjJrTL8ObEmExVmXp-Ag

P.S. This files are aweful. But I have no enought knowledges to improve it.

P.P.S. Tested. Board works.
Related issue armbian/build#7295

@buldo buldo changed the title DTS for Luckfox Core3566 arm64: dts: DTS for Luckfox Core3566 Oct 2, 2024
Copy link
Copy Markdown
Member

@SuperKali SuperKali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the CI fails as the file corresponding to the board dts is missing:

  make[3]: *** No rule to make target 'arch/arm64/boot/dts/rockchip/rk3566-luckfox-core3566.dtb', needed by 'arch/arm64/boot/dts/rockchip/'.  Stop.
   make[3]: *** Waiting for unfinished jobs....

I suggest you review the dts, usually the ones provided by the vendor are not put together so well and are quite confusing, which leads you to rewrite them from 0.

@rpardini
Copy link
Copy Markdown
Member

rpardini commented Oct 3, 2024

Yeah and at least rename (or use a placeholder include) to adhere to the naming convention that exists in the directory. Also maybe just gather all includes in a single thing.

@buldo
Copy link
Copy Markdown
Contributor Author

buldo commented Oct 3, 2024

@SuperKali I forgot most important dts. Added in the second commit.
@rpardini are there special command for dts preprocess? I mean to prepare single dts with all includes?

And one more question:
core3566-mipi-dsi* files are related to dsi imege output. Vendor just provides 3 different sd card images. What should I do with this files?

@SuperKali
Copy link
Copy Markdown
Member

core3566-mipi-dsi* files are related to dsi imege output.

I think they cannot be activated at the same time and one of them must be disabled

Vendor just provides 3 different sd card images. What should I do with this files?

I usually recommend creating a single file and integrating an if function, although it would make sense to create an overlay for the latter

@buldo
Copy link
Copy Markdown
Contributor Author

buldo commented Oct 3, 2024

@SuperKali will try to provide single dts after this weekend

@buldo
Copy link
Copy Markdown
Contributor Author

buldo commented Oct 7, 2024

@SuperKali now dts is single file.
I tested it with my board with HDMI and Ethernet.
My board have no emmc and WiFi/BT so I not able to test it.

Copy link
Copy Markdown
Member

@SuperKali SuperKali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, perfect!

@SuperKali SuperKali merged commit 35278ab into armbian:rk-6.1-rkr3 Oct 8, 2024
amazingfate pushed a commit that referenced this pull request Nov 24, 2024
* Device tree files from vendor SDK
* core3566 files update
* Luckfox core merged to single dts
---------
Co-authored-by: SuperKali <hello@superkali.me>
HeyMeco pushed a commit to HeyMeco/linux-rockchip that referenced this pull request Jan 26, 2025
* Device tree files from vendor SDK
* core3566 files update
* Luckfox core merged to single dts
---------
Co-authored-by: SuperKali <hello@superkali.me>
HeyMeco pushed a commit that referenced this pull request Apr 15, 2025
* Device tree files from vendor SDK
* core3566 files update
* Luckfox core merged to single dts
---------
Co-authored-by: SuperKali <hello@superkali.me>
HeyMeco pushed a commit that referenced this pull request Apr 15, 2025
* Device tree files from vendor SDK
* core3566 files update
* Luckfox core merged to single dts
---------
Co-authored-by: SuperKali <hello@superkali.me>
HeyMeco pushed a commit to HeyMeco/linux-rockchip that referenced this pull request Aug 28, 2025
* Device tree files from vendor SDK
* core3566 files update
* Luckfox core merged to single dts
---------
Co-authored-by: SuperKali <hello@superkali.me>
SergeyKharenko pushed a commit to SergeyKharenko/linux-rockchip that referenced this pull request Mar 21, 2026
* Device tree files from vendor SDK
* core3566 files update
* Luckfox core merged to single dts
---------
Co-authored-by: SuperKali <hello@superkali.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants