Skip to content

fix: add ModelDescription type to binary test callbacks#11888

Merged
RomneyDa merged 1 commit intomainfrom
dallin/jb64-fix
Mar 26, 2026
Merged

fix: add ModelDescription type to binary test callbacks#11888
RomneyDa merged 1 commit intomainfrom
dallin/jb64-fix

Conversation

@RomneyDa
Copy link
Copy Markdown
Contributor

@RomneyDa RomneyDa commented Mar 26, 2026

Summary

  • Fixes TS7006 implicit any type errors in binary/test/binary.test.ts that broke the JetBrains 1.0.64 release CI
  • Adds explicit ModelDescription type annotation to .some() callback parameters on lines 238 and 247

Test plan

  • Re-run JetBrains release after merging (re-tag v1.0.64-jetbrains)

Summary by cubic

Fixes TS7006 implicit any errors in binary/test/binary.test.ts by adding ModelDescription types to .some() callbacks when checking chat model titles. This restores type safety and unblocks the JetBrains 1.0.64 release CI.

Written for commit 96754dc. Summary will update on new commits.

Fixes TS7006 implicit any errors that broke JetBrains release CI.
@RomneyDa RomneyDa requested a review from a team as a code owner March 26, 2026 16:40
@RomneyDa RomneyDa requested review from sestinj and removed request for a team March 26, 2026 16:40
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 26, 2026
@continue
Copy link
Copy Markdown
Contributor

continue bot commented Mar 26, 2026

Docs Review: No documentation updates needed.

This PR adds explicit ModelDescription type annotations to callback parameters in a test file (binary/test/binary.test.ts). This is an internal type safety improvement that doesn't affect any user-facing APIs, configuration, or documented behavior.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Mar 26, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 26, 2026
@RomneyDa RomneyDa merged commit 7f32540 into main Mar 26, 2026
67 checks passed
@RomneyDa RomneyDa deleted the dallin/jb64-fix branch March 26, 2026 17:46
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Mar 26, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants