Fix healthcheck interceptors#6257
Merged
alanprot merged 1 commit intocortexproject:masterfrom Oct 10, 2024
Merged
Conversation
alanprot
force-pushed
the
fix/healthcheck
branch
from
5722755 to
63dc59a
Compare
Signed-off-by: alanprot <alanprot@gmail.com>
alanprot
force-pushed
the
fix/healthcheck
branch
from
63dc59a to
851afdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fix connection leak on the health check. See #6225
This happened when the healthcheck interval was > than 1 second. In this case we were opening the connections and not closing it.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]