Disable chunk trimming in ingester#6270
Merged
yeya24 merged 1 commit intocortexproject:masterfrom Oct 25, 2024
Merged
Conversation
SungJin1212
force-pushed
the
Disable-chunk-trimming
branch
2 times, most recently
from
0b0281b to
02a50e8
Compare
yeya24
reviewed
Oct 17, 2024
integration/query_fuzz_test.go
Outdated
| expr := ps.WalkRangeQuery() | ||
| query := expr.Pretty(0) | ||
| res1, err1 := c1.QueryRange(query, start, end, scrapeInterval) | ||
| res2, err2 := c2.QueryRange(query, start, end, scrapeInterval) |
Contributor
There was a problem hiding this comment.
We need to change the time range here probably. Chunks trimming happens when the requested time range is within the Chunk range.
|-------------| chunk
|-------| requested range
So a chunk should contain 120 samples. With 15s scrape interval a chunk will be roughly 30min.
It is better to reduce time range < 30min so that we know it triggers chunks trimming
SungJin1212
force-pushed
the
Disable-chunk-trimming
branch
from
02a50e8 to
9e1d981
Compare
yeya24
approved these changes
Oct 19, 2024
Contributor
yeya24
left a comment
yeya24
left a comment
There was a problem hiding this comment.
THanks! Thanks for adding the test
SungJin1212
force-pushed
the
Disable-chunk-trimming
branch
from
9e1d981 to
d8b6469
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
Disable-chunk-trimming
branch
from
d8b6469 to
217c867
Compare
CharlieTLe
pushed a commit
to CharlieTLe/cortex
that referenced
this pull request
Oct 27, 2024
Signed-off-by: Charlie Le <charlie_le@apple.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable chunk trimming in Ingesters to skip duplicated works in the query engine and Ingesters.
Which issue(s) this PR fixes:
Fixes #6269
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]