Add list objects version to s3 config#6280
Merged
yeya24 merged 1 commit intocortexproject:masterfrom Oct 24, 2024
Merged
Conversation
SungJin1212
changed the title
Contributor
|
Let's fix changelog |
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
Add-list-objects-version
branch
from
d51fc49 to
2fb17b5
Compare
Member
Author
|
@yeya24 |
yeya24
approved these changes
Oct 24, 2024
CharlieTLe
pushed a commit
to CharlieTLe/cortex
that referenced
this pull request
Oct 27, 2024
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> Signed-off-by: Charlie Le <charlie_le@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
-blocks-storage.s3.list-objects-versionto configure s3 list API version.Use case: If users use s3 compatible backends that don't fully support
ListObjectV2, they (including me) would want to use V1 api.The thanos expose it (https://github.com/thanos-io/objstore/blob/23ebe2eacadd89cf23bf0fbd931352112b4c846d/providers/s3/s3.go#L137).
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]