Replace cespare/xxhash with cespare/xxhash/v2#6467
Merged
yeya24 merged 1 commit intocortexproject:masterfrom Dec 31, 2024
Juneezee:xxhash
Merged
Replace cespare/xxhash with cespare/xxhash/v2#6467yeya24 merged 1 commit intocortexproject:masterfrom Juneezee:xxhash
cespare/xxhash with cespare/xxhash/v2#6467yeya24 merged 1 commit intocortexproject:masterfrom
Juneezee:xxhash
Conversation
`github.com/cespare/xxhash/v2` is the latest version with bug fixes and improvements. This commit also updates Thanos to pull thanos-io/thanos#8018. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
dosubot
bot
added
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Currently, we are using two versions of the same package for xxHash:
cortex/go.mod
Line 12 in 5d593f5
cortex/go.mod
Line 81 in 5d593f5
github.com/cespare/xxhash/v2is the latest version, which includes bug fixes and improvements. No breaking changes, see https://go.dev/play/p/q35yQ6UUE5A.This PR updates the codebase to replace
github.com/cespare/xxhashwithgithub.com/cespare/xxhash/v2. This PR also updates Thanos to pull thanos-io/thanos#8018.Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]