Implement matchers cache on Ingester#6477
Merged
alanprot merged 5 commits intocortexproject:masterfrom Jan 6, 2025
Merged
Conversation
Member
Author
|
Blocked by thanos-io/thanos#8039 |
Signed-off-by: alanprot <alanprot@gmail.com>
alanprot
force-pushed
the
matcher-cache
branch
from
59d5171 to
45ccce0
Compare
alanprot
changed the title
yeya24
reviewed
Jan 6, 2025
Signed-off-by: alanprot <alanprot@gmail.com>
alanprot
force-pushed
the
matcher-cache
branch
from
0f0de00 to
5e0d931
Compare
Signed-off-by: Alan Protasio <approtas@amazon.com>
yeya24
approved these changes
Jan 6, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implement matchers cache on ingesters.
The cache can be configured using the new
matchers_cache_max_itemsconfig.Supersedes #6382
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]