Merged
Conversation
27d4ca3 to
7ab5bc7
Compare
yeya24
reviewed
Oct 19, 2025
| assert.Equal(t, codes.InvalidArgument, s.Code()) | ||
| } | ||
|
|
||
| func TestChunkToStoreEncoding(t *testing.T) { |
Contributor
There was a problem hiding this comment.
This test seems irrelevant?
Contributor
There was a problem hiding this comment.
Do we still want to keep this test?
Member
Author
|
@yeya24 |
Contributor
|
Can u please update the PR title and description? |
336be55 to
553e4ea
Compare
yeya24
reviewed
Oct 24, 2025
e63931b to
840bf27
Compare
yeya24
reviewed
Nov 1, 2025
9e370dc to
b4a039c
Compare
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
b4a039c to
29642eb
Compare
Contributor
|
For future PRs we may want to add the parquet metadata cache to store gateway and support #6991 |
yeya24
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new parquet mode for the Store Gateway. In this initial version, the mode operates statelessly and does not perform operations such as block syncing. The primary improvement is to enhance cache utilization by leveraging the Store Gateway's block affinity.
Which issue(s) this PR fixes:
Fixes #6940
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]