Add limits to reject unoptimized regex queries on Ingester#7194
Merged
yeya24 merged 7 commits intocortexproject:masterfrom Jan 9, 2026
Merged
Add limits to reject unoptimized regex queries on Ingester#7194yeya24 merged 7 commits intocortexproject:masterfrom
yeya24 merged 7 commits intocortexproject:masterfrom
Conversation
Signed-off-by: yeya24 <benye@amazon.com>
dosubot
bot
added
the
type/production
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
reject-regex-matcher-cardinality
branch
from
f4840f7 to
102732d
Compare
danielblando
reviewed
Jan 7, 2026
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: yeya24 <benye@amazon.com>
SungJin1212
reviewed
Jan 8, 2026
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: yeya24 <benye@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Unoptimized regex matchers in PromQL queries can be extremely expensive to evaluate, especially when applied to high-cardinality labels. These queries can cause significant resource consumption and impact cluster performance. While Prometheus optimizes certain regex patterns (like .*, .+, prefix/suffix matches), unoptimized patterns must be evaluated against every label value, making the cost proportional to:
This PR introduces per-tenant configurable limits to reject such expensive queries before they consume excessive resources.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]