Fix alertmanager reloading bug that removes user template files#7196
Merged
friedrichg merged 1 commit intocortexproject:masterfrom Jan 8, 2026
Merged
Conversation
Signed-off-by: Charlie Le <charlie_le@apple.com>
CharlieTLe
force-pushed
the
cortex-alertmanager-stale-templates-bug
branch
from
505c5ed to
d1cc2b1
Compare
friedrichg
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
When the data_dir path is set to the default of data/, the path that Cortex uses to compare won't include the front leading /. This differs from safeTemplateFilepath which returns the fully-qualified path name that includes the front leading /. This will cause Cortex to delete the template files provided by the user on every other poll interval which causes inconsistent templating by the alertmanager.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]