feat: mnlistdiff move nversion to first position#5450
Merged
PastaPastaPasta merged 1 commit intodashpay:developfrom Jun 26, 2023
ogabrielides:mnlistdiff_version_order
Merged
feat: mnlistdiff move nversion to first position#5450PastaPastaPasta merged 1 commit intodashpay:developfrom ogabrielides:mnlistdiff_version_order
PastaPastaPasta merged 1 commit intodashpay:developfrom
ogabrielides:mnlistdiff_version_order
Conversation
Member
|
light-NACK; Yes the version should be first but... do we really need to change it? I'd prefer to just avoid the complexity and added proto version unless mobile will have a hard time without this change (which looking at it, maybe they will/would, but I want that clarified) |
UdjinM6
approved these changes
Jun 22, 2023
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
utACK
@PastaPastaPasta It's not necessary atm, true. But it's trivial and mnlistdiff is going to be changed in #5377/v20 anyway so why not clean things up while we are at it?
PastaPastaPasta
approved these changes
Jun 26, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge; okay
thephez
added a commit
to thephez/docs-core
that referenced
this pull request
Aug 16, 2023
thephez
added a commit
to dashpay/docs-core
that referenced
this pull request
Aug 30, 2023
* docs: deprecate MSG_LEGACY_TXLOCK_REQUEST Aligns with dashpay/dash#5483 * chore: update link to prev version of docs * docs: update mnlistdiff nversion location Relates to dashpay/dash#5450 * docs(p2p): update mnlistdiff Relates to dashpay/dash#5377 * docs: update cbtx for v3 Relates to dashpay/dash#5262 * docs: update mnhf with details of final implementation Relates to dashpay/dash#5469 and dashpay/dash#5505 * docs: note removal of NODE_GETUTXO Relates to dashpay/dash#5500 * chore: revert "docs: update mnhf with details of final implementation" This reverts commit 8e4bf6c since there may still be additional changes to the implementation (it's not merged)
thephez
added a commit
to thephez/docs-core
that referenced
this pull request
Sep 27, 2023
* docs: deprecate MSG_LEGACY_TXLOCK_REQUEST Aligns with dashpay/dash#5483 * chore: update link to prev version of docs * docs: update mnlistdiff nversion location Relates to dashpay/dash#5450 * docs(p2p): update mnlistdiff Relates to dashpay/dash#5377 * docs: update cbtx for v3 Relates to dashpay/dash#5262 * docs: update mnhf with details of final implementation Relates to dashpay/dash#5469 and dashpay/dash#5505 * docs: note removal of NODE_GETUTXO Relates to dashpay/dash#5500 * chore: revert "docs: update mnhf with details of final implementation" This reverts commit 8e4bf6c since there may still be additional changes to the implementation (it's not merged)
thephez
added a commit
to dashpay/docs-core
that referenced
this pull request
Nov 15, 2023
* docs: deprecate MSG_LEGACY_TXLOCK_REQUEST Aligns with dashpay/dash#5483 * chore: update link to prev version of docs * docs: update mnlistdiff nversion location Relates to dashpay/dash#5450 * docs(p2p): update mnlistdiff Relates to dashpay/dash#5377 * docs: update cbtx for v3 Relates to dashpay/dash#5262 * docs: update mnhf with details of final implementation Relates to dashpay/dash#5469 and dashpay/dash#5505 * docs: note removal of NODE_GETUTXO Relates to dashpay/dash#5500 * chore: revert "docs: update mnhf with details of final implementation" This reverts commit 8e4bf6c since there may still be additional changes to the implementation (it's not merged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Version field should always be the first field of a message for better readibility.
What was done?
MNLISTDIFF_VERSION_ORDER(70229).nVersionserialisation order is changed for clients with protocol version greater than or equal to70229.70225and <70229the old order is used: can be deprecated in the future.70229.How Has This Been Tested?
feature_llmq_rotation.pywith new protocol version.Breaking Changes
cc @HashEngineering
Checklist: