Bump OSX runner image to 14#21985
Conversation
|
Thanks for your pull request and interest in making D better, @rikkimax! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#21985" |
|
It appears OSX-15 doesn't have 80bit reals. |
|
Ugh oh.
|
|
Bootstrap compiler not supporting macos-14: #21986 |
|
x87 not supported by macos-15: #21987 |
3775a15 to
25acd12
Compare
|
Code coverage for OSX is still dead, disabling again. |
|
I'll bump the timeout to 1 hour. I hate doing it, but we must see OSX runner pass. Also: |
e6229af to
4e5416d
Compare
|
druntime still failing:
|
|
Ohh I see, I think its this that is causing the issue:
|
|
Gonna try the fix that everyone else is using for this (change in linker for XCode 15): https://indiestack.com/2023/10/xcode-15-duplicate-library-linker-warnings/ |
6313b9f to
baa7524
Compare
|
That did not work. I can't fix that, nor run it locally. |
10de2a7 to
ecfee8b
Compare
|
Hmm, I bet if I forced the solution I said above about duplicate libraries for OSX would be good enough here. It must be outputting it to stderr: |
|
If I've applied it correctly, it does mean XCode < 15 won't work with dmd anymore. |
|
Hmm I wonder if CC is linking against those two libraries by default, and we shouldn't be specifying them on OSX at all. |
|
If bumping to 16.2 fixes make not having the private modifier, then I need to verify if we still need |
a698bca to
37018fb
Compare
|
After many days I have learned that something is forcing the XCode's make over homebrew's gmake. Put the right path into a var at the right place, and ignore the symlink and it seems to be working. |
|
I now have permissions, and I have removed osx13 as a requirement. Will revisit this when not as tired as I am now as to if it should merge. |
|
Ok, I'm happy. |
No description provided.