Skip to content

Bump OSX runner image to 14#21985

Merged
thewilsonator merged 1 commit intodlang:masterfrom
rikkimax:bump-osx-14
Oct 21, 2025
Merged

Bump OSX runner image to 14#21985
thewilsonator merged 1 commit intodlang:masterfrom
rikkimax:bump-osx-14

Conversation

@rikkimax
Copy link
Copy Markdown
Contributor

No description provided.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @rikkimax! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#21985"

@rikkimax
Copy link
Copy Markdown
Contributor Author

It appears OSX-15 doesn't have 80bit reals.

@rikkimax
Copy link
Copy Markdown
Contributor Author

Ugh oh.

ld: multiple errors: symbol count from symbol table and dynamic symbol table differ in '/Users/runner/work/dmd/dmd/generated/build.o' in '/Users/runner/work/dmd/dmd/generated/build.o'; address=0x0 points to section(2) with no content in '/Users/runner/dlang/dmd-2.099.1/osx/lib/libphobos2.a2942'

@rikkimax
Copy link
Copy Markdown
Contributor Author

rikkimax commented Oct 17, 2025

Bootstrap compiler not supporting macos-14: #21986

@rikkimax
Copy link
Copy Markdown
Contributor Author

rikkimax commented Oct 17, 2025

x87 not supported by macos-15: #21987

@rikkimax rikkimax force-pushed the bump-osx-14 branch 2 times, most recently from 3775a15 to 25acd12 Compare October 17, 2025 01:13
@rikkimax rikkimax changed the title Bump OSX runner image to 14&15 Bump OSX runner image to 14 Oct 17, 2025
@rikkimax
Copy link
Copy Markdown
Contributor Author

Code coverage for OSX is still dead, disabling again.

@rikkimax
Copy link
Copy Markdown
Contributor Author

I'll bump the timeout to 1 hour. I hate doing it, but we must see OSX runner pass.

Also: macOS 13 x64, DMD (bootstrap) needs to be removed from the repository settings as required to be completed.

@rikkimax rikkimax force-pushed the bump-osx-14 branch 3 times, most recently from e6229af to 4e5416d Compare October 17, 2025 06:36
@rikkimax
Copy link
Copy Markdown
Contributor Author

druntime still failing:

Testing merge
ld: warning: ignoring duplicate libraries: '-lm', '-lpthread'
generated/osx/debug/64/merge ./generated/osx/debug/64
Testing merge_true
generated/osx/debug/64/merge_true ./generated/osx/debug/64
ld: warning: ignoring duplicate libraries: '-lm', '-lpthread'
make: *** [unittest-release] Error 2
make: *** Waiting for unfinished jobs....
Testing no_code
generated/osx/debug/64/no_code ./generated/osx/debug/64
generated/osx/debug/64/merge_true ./generated/osx/debug/64
generated/osx/debug/64/merge ./generated/osx/debug/64
diff --strip-trailing-cr src-merge_true.lst.exp ./generated/osx/debug/64/src-merge_true.lst
cp src/merge_override.d generated/osx/debug/64/1/src/merge_override.d
cp src/merge_override.d generated/osx/debug/64/2/src/merge_override.d
sed -i '' 's/CHANGE_VAR/CHANGEVAR/g' generated/osx/debug/64/2/src/merge_override.d
diff --strip-trailing-cr src-merge.lst.exp ./generated/osx/debug/64/src-merge.lst
Testing merge_override
generated/osx/debug/64/merge_override ./generated/osx/debug/64 ./generated/osx/debug/64/1
generated/osx/debug/64/no_code ./generated/osx/debug/64
diff --strip-trailing-cr src-no_code.lst.exp ./generated/osx/debug/64/src-no_code.lst
diff --strip-trailing-cr src-no_code_imp.lst.exp ./generated/osx/debug/64/src-no_code_imp.lst
diff --strip-trailing-cr src-merge_override.lst_1.exp ./generated/osx/debug/64/src-merge_override.lst
generated/osx/debug/64/merge_override ./generated/osx/debug/64 ./generated/osx/debug/64/2
diff --strip-trailing-cr src-merge_override.lst_2.exp ./generated/osx/debug/64/src-merge_override.lst
make: *** [unittest-debug] Error 2

@rikkimax
Copy link
Copy Markdown
Contributor Author

Ohh I see, I think its this that is causing the issue:

ld: warning: ignoring duplicate libraries: '-lm', '-lpthread'

@rikkimax
Copy link
Copy Markdown
Contributor Author

Gonna try the fix that everyone else is using for this (change in linker for XCode 15): https://indiestack.com/2023/10/xcode-15-duplicate-library-linker-warnings/

@rikkimax rikkimax force-pushed the bump-osx-14 branch 2 times, most recently from 6313b9f to baa7524 Compare October 17, 2025 09:38
@rikkimax
Copy link
Copy Markdown
Contributor Author

That did not work.

I can't fix that, nor run it locally.

@rikkimax rikkimax force-pushed the bump-osx-14 branch 2 times, most recently from 10de2a7 to ecfee8b Compare October 19, 2025 12:28
@rikkimax
Copy link
Copy Markdown
Contributor Author

Hmm, I bet if I forced the solution I said above about duplicate libraries for OSX would be good enough here.

It must be outputting it to stderr:

ld: warning: ignoring duplicate libraries: '-lm', '-lpthread'
rm generated/osx/debug/64/invalid_memory_operation generated/osx/debug/64/stderr_msg

@rikkimax
Copy link
Copy Markdown
Contributor Author

If I've applied it correctly, it does mean XCode < 15 won't work with dmd anymore.

@rikkimax
Copy link
Copy Markdown
Contributor Author

Hmm I wonder if CC is linking against those two libraries by default, and we shouldn't be specifying them on OSX at all.

@rikkimax
Copy link
Copy Markdown
Contributor Author

If bumping to 16.2 fixes make not having the private modifier, then I need to verify if we still need -Wl,-no_warn_duplicate_libraries if we don't need this linker flag then this won't need a changelog.

@rikkimax rikkimax force-pushed the bump-osx-14 branch 10 times, most recently from a698bca to 37018fb Compare October 20, 2025 05:47
@rikkimax
Copy link
Copy Markdown
Contributor Author

After many days I have learned that something is forcing the XCode's make over homebrew's gmake.

Put the right path into a var at the right place, and ignore the symlink and it seems to be working.

@rikkimax
Copy link
Copy Markdown
Contributor Author

I now have permissions, and I have removed osx13 as a requirement. Will revisit this when not as tired as I am now as to if it should merge.

@rikkimax
Copy link
Copy Markdown
Contributor Author

Ok, I'm happy.

@thewilsonator thewilsonator merged commit 04034d6 into dlang:master Oct 21, 2025
42 checks passed
rikkimax added a commit to rikkimax/dmd that referenced this pull request Jan 30, 2026
thewilsonator pushed a commit that referenced this pull request Jan 31, 2026
This was referenced Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants