Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates exported image commands and moves their implementation to unexported functions as part of a refactoring effort. The goal is to prepare for removing these exported functions in a future release while maintaining backward compatibility through wrapper functions.
- Adds deprecation warnings to all exported
New*Commandfunctions in the image package - Creates new unexported
new*Commandfunctions containing the actual implementation - Updates internal usages and tests to use the new unexported functions
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cli/command/image/build.go | Deprecates NewBuildCommand and creates unexported newBuildCommand |
| cli/command/image/history.go | Deprecates NewHistoryCommand and creates unexported newHistoryCommand |
| cli/command/image/import.go | Deprecates NewImportCommand and creates unexported newImportCommand |
| cli/command/image/list.go | Deprecates NewImagesCommand and creates unexported newImagesCommand |
| cli/command/image/load.go | Deprecates NewLoadCommand and creates unexported newLoadCommand |
| cli/command/image/prune.go | Deprecates NewPruneCommand and creates unexported newPruneCommand |
| cli/command/image/pull.go | Deprecates NewPullCommand and creates unexported newPullCommand |
| cli/command/image/push.go | Deprecates NewPushCommand and creates unexported newPushCommand |
| cli/command/image/remove.go | Deprecates NewRemoveCommand and creates unexported newRemoveCommand |
| cli/command/image/save.go | Deprecates NewSaveCommand and creates unexported newSaveCommand |
| cli/command/image/tag.go | Deprecates NewTagCommand and creates unexported newTagCommand |
| cli/command/image/cmd.go | Updates to use new unexported functions and adds staticcheck suppressions |
| cli/command/commands/commands.go | Adds staticcheck suppressions for deprecated command usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This patch deprecates exported image commands and moves the implementation details to an unexported function. Commands that are affected include: - image.NewBuildCommand - image.NewPullCommand - image.NewPushCommand - image.NewImagesCommand - image.NewImageCommand - image.NewHistoryCommand - image.NewImportCommand - image.NewLoadCommand - image.NewRemoveCommand - image.NewSaveCommand - image.NewTagCommand - image.NewPruneCommand Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
1b19c27 to
e66a145
Compare
This patch deprecates exported image commands and moves the implementation details to an unexported function.
Commands that are affected include:
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)