Conversation
dd8a4f6 to
cf5545b
Compare
cf5545b to
bb51e16
Compare
bb51e16 to
10be5f1
Compare
martinjaggi
approved these changes
Mar 1, 2024
JulienVig
reviewed
Mar 4, 2024
JulienVig
reviewed
Mar 4, 2024
JulienVig
reviewed
Mar 4, 2024
JulienVig
reviewed
Mar 4, 2024
JulienVig
reviewed
Mar 4, 2024
Collaborator
|
For what it's worth very good stuff! I only left comments for what I didn't understand but it's a very nice refactoring |
Merged
Collaborator
Author
héhé, thanks 😄 followup of fixes from your remarks #645 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merging LLM (from #619) requires some reshaping of the code, here goes some changes splitted from the original PR.
Modelabstracting away tensorflow specificstf.Tensorsfor now, and one can extract thetf.LayersModelTask.training.modelCompileDataas it's now contained inside themodels.TFJSTask.taskIDtoTask.id