Merged
Conversation
tharvik
force-pushed
the
NAN-test-aggregator-tharvik
branch
3 times, most recently
from
11d9372 to
3ad79d3
Compare
JulienVig
approved these changes
May 28, 2024
Collaborator
JulienVig
left a comment
JulienVig
left a comment
There was a problem hiding this comment.
Looks good thanks for the tests!
No blocking comments, only questions for my own understanding
tharvik
force-pushed
the
NAN-test-aggregator-tharvik
branch
from
dea2a6a to
a31a953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to check that the secure aggregator is working, it's better to have some tests for the aggregator
not too much code change, the implementations are pretty much the same.