Map textContentType strings to Objective-C constants#22579
Closed
levibuzolic wants to merge 1 commit intofacebook:masterfrom
Closed
Map textContentType strings to Objective-C constants#22579levibuzolic wants to merge 1 commit intofacebook:masterfrom
levibuzolic wants to merge 1 commit intofacebook:masterfrom
Conversation
2edf7bc to
792c06b
Compare
facebook-github-bot
approved these changes
Dec 10, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@levibuzolic merged commit 077386a into |
Contributor
|
Ooops, this diff was reverted because of some internal breakage. I will try to understand the exact reason and fix later this week. |
Member
|
This PR failed with this log: |
Contributor
|
Probably needs some #ifdef around the constants that are not defined in older ios versions. |
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Jul 18, 2019
Summary: Fixes #22578 Currently the only `textContentType` values that work are: `username`, `password`, `location`, `name` and `nickname`. This is due to the strings provided by React Native not matching up with the underlying string constants used in iOS (with the exception of the aforementioned types). Issue #22578 has more detail examples/explanation. Pull Request resolved: facebook/react-native#22579 Differential Revision: D13402177 Pulled By: shergin fbshipit-source-id: 55f4a2029cd3ea1fb4834e9f56d2df5a05b31b4e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22578
Currently the only
textContentTypevalues that work are:username,password,location,nameandnickname. This is due to the strings provided by React Native not matching up with the underlying string constants used in iOS (with the exception of the aforementioned types). Issue #22578 has more detail examples/explanation.Test Plan:
Added a Text Content Type example to the RNTester app which shows two examples which weren't previously working.
Changelog:
[iOS] [Fixed] - Fixes textContentTypes not working by mapping textContentType strings to Objective-C constants - Fixes #22578