Skip to content

Add initial backend test #48

Merged
Celebio merged 2 commits intofacebookresearch:seamlistenfrom
david-wagih:add-initial-backend-test
Jul 27, 2023
Merged

Add initial backend test #48
Celebio merged 2 commits intofacebookresearch:seamlistenfrom
david-wagih:add-initial-backend-test

Conversation

@david-wagih
Copy link
Copy Markdown

@david-wagih david-wagih commented Jul 11, 2023

Why ?

to start adding tests for each endpoint we have now or added later, and that is important for our code maintainability.

How ?

started using pytest for writing my initial test.

Test plan

in the root directory of the backend folder inside seamlisten app folder,
type the command pytest which will trigger all the tests written in the project.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2023
@david-wagih
Copy link
Copy Markdown
Author

can you please take a look @Celebio
issue #35

Copy link
Copy Markdown
Member

@Celebio Celebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Were you able to run the test without the background fully operational?

@david-wagih
Copy link
Copy Markdown
Author

david-wagih commented Jul 18, 2023

LGTM. Were you able to run the test without the background fully operational?

I tried to run these tests for the base endpoints in the static.py file, but I didn;t add tests yet for the endpoints that are not working with me yet
@Celebio

@Celebio Celebio merged commit 14bf58b into facebookresearch:seamlisten Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants