fix(vue): Improve type definitions for framework7-vue/bundle#4075
Merged
nolimits4web merged 1 commit intoframework7io:masterfrom Oct 31, 2022
Merged
fix(vue): Improve type definitions for framework7-vue/bundle#4075nolimits4web merged 1 commit intoframework7io:masterfrom
nolimits4web merged 1 commit intoframework7io:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The framework7-vue type definitions inaccurately suggest
registerComponentsis exported by theframework7-vuemodule. Thepackage.jsonalso lacks any way for TypeScript to tell what the type definitions are for the bundle module.This slight adjust fixes both of these requirements. The hint on using
typeVersionscomes from https://stackoverflow.com/a/70020984/156169Before these fixes:
After these fixes, this is what TypeScript reports:
