Supporting functionalities for direct migration#283
Supporting functionalities for direct migration#283josephlr merged 2 commits intogoogle:tpmdirectfrom
Conversation
josephlr
left a comment
There was a problem hiding this comment.
One idea worth considering here is which direction we want to support conversion for the TPM types. We can support:
- Using the new TPM type (
transport.TPM) with the old TPM interface (io.ReadWriter/io.ReadWriteCloser) and library. - Using the old TPM type (
io.ReadWriter) with the new TPM interface (transport.TPM) and library
This PR implements (2), but I'm wondering if we should implement (1) instead.
This PR implements 2 because the old tests still need RWC and the Direct Migration needs a RW in order to be made a transport tpm used for Execute. Correct me if I'm wrong but eventually we will only have 1 interface. |
josephlr
left a comment
There was a problem hiding this comment.
@matt-tsai let us know when this is ready for review again (and the TODO comments are cleaned up).
Added and changed names of private Types and return types of OpenTPM.
9c2c18c to
63fd70e
Compare
chrisfenner
left a comment
There was a problem hiding this comment.
Thanks for the change, looks great. Only teeny nits
josephlr
left a comment
There was a problem hiding this comment.
Other than the Read implementation, LGTM
35859f1 to
a3e0580
Compare
|
Nice work on this!!! |
Main changes include: ReadWrite interface for transport TPMs, adding util to grab HandleValue.