Allow callers to omit handles from commands when RH_NULL#344
Merged
chrisfenner merged 1 commit intogoogle:mainfrom Sep 13, 2023
Merged
Allow callers to omit handles from commands when RH_NULL#344chrisfenner merged 1 commit intogoogle:mainfrom
chrisfenner merged 1 commit intogoogle:mainfrom
Conversation
alexmwu
approved these changes
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I observed that the both the following will fail:
with a message like
because their
handletagged values of typetpm2.handle, while markednullable, were failing type assertions tohandleduring the reflection based marshalling.Investigating this led me to learn that type assertions on nil-valued interface-typed variables (such as
handle-typed TPM command struct fields) will fail due to the design of the language.To improve the usability of go-tpm and allow callers to leave out handles in commands when NULL is desired, this change adds logic to treat any nil-valued interface-typed command variable (when annotated with
gotpm:handle) asTPM_RH_NULL. This allows us to remove thenullableannotation from those fields, which makes sense. It's an interface, the user can always (try to) pass nil, and this should always meanTPM_RH_NULL.