tpm2: Implement TPM2_TestParms#352
Merged
chrisfenner merged 1 commit intogoogle:mainfrom Apr 11, 2024
Merged
Conversation
chrisfenner
requested changes
Apr 11, 2024
Member
chrisfenner
left a comment
chrisfenner
left a comment
There was a problem hiding this comment.
Sorry for the delayed response.
Looks good, just needs a typo fix. I made one other optional suggestion if you're up for it.
Member
|
(not sure if the force-push worked as intended; the linter that was updated in #353 now notices the typo) |
Contributor
Author
Forgot to pull 🙃 |
Signed-off-by: Morten Linderud <morten@linderud.pw>
Contributor
Author
|
And it turns out i misspelled the word twice fixing it up. Great job. |
Member
|
Perfect, looks right now. Thank you for taking me up on the optional testing suggestion! After linters and tests finish up I'll merge. |
chrisfenner
approved these changes
Apr 11, 2024
Member
Good to know I'm not the only person who does this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.