Merged
Conversation
chessai
approved these changes
May 8, 2021
emilypi
approved these changes
May 9, 2021
Member
emilypi
left a comment
emilypi
left a comment
There was a problem hiding this comment.
Looks like a great start. Just one non-blocking question.
phadej
reviewed
May 9, 2021
| cpp-options: -DASSERTS | ||
|
|
||
| if impl(ghc >= 8.11) | ||
| build-depends: ghc-bignum |
Contributor
There was a problem hiding this comment.
removal of this is very nice.
Contributor
|
Do we want to merge that soon or should we rather wait so the next release (which has quite some stuff already) remains more widely compatible? |
Contributor
Author
|
Feel free to release current |
Lysxia
approved these changes
May 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed at previous maintainers meetings.
A utf8 journey would go smoother without worrying about ancient GHCs.
CC @chessai @emilypi