add some utf8 decoding convenience functions#342
Merged
Lysxia merged 1 commit intohaskell:masterfrom May 25, 2021
Merged
Conversation
Lysxia
previously approved these changes
May 25, 2021
Contributor
|
Looks good to me. I assume @haskell/text won't object to this. @pdedmon Can you resolve the conflicts? |
Contributor
|
|
Contributor
|
It's arguable that |
Contributor
Author
|
Shall I reduce this down to just |
Contributor
|
Let's do that, yes. |
07cf795 to
b42f915
Compare
Contributor
Author
|
Done and rebased. |
Lysxia
approved these changes
May 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #341.
Let me know if I should add any INLINE pragmas or "since" notes in the docs.