Switch Data.Text.Array to Data.Array.Byte

[Bodigrim]

This is a part of a grand plan to unify ShortByteString, Data.Text.Array and Data.Primitive.ByteArray to share the same data type. If it looks good, I'll make a release of data-array-byte package.

[phadej]

This is technically a breaking change as Data.Text.Array is just an ordinary public module, with Array being public type.

An example of possible problems: any instances for Data.Text.Array.Array (and Data.Primitive.ByteArray ...)

[Bodigrim]

I hoped no one ever defined instances for Data.Text.Array, but https://hackage.haskell.org/package/isomorphism-class-0.1.0.7/docs/IsomorphismClass.html does. Sigh. Well, then a breaking change it is.

[phadej]

I hoped no one ever defined instances for Data.Text.Array

You cannot ever know what (kind of weird stuff) people do in private projects. IMO we cannot assume no-one does anything weird, only that is very rare.

EDIT: PVP is also quite unambiguous, breaking change is breaking change even no-one observes it. Someone might observe it in future by writing instances to ease transition! (though they probably end up needing to use CPP, having CPP-guards at major bounds is definitely more welcome).

[Bodigrim]

Perhaps this has to wait until GHC 9.4 becomes a bootstrap version, otherwise I imagine Hadrian might be troubled...

[Bodigrim]

Cf. haskell/primitive#359 and haskell/bytestring#410.

This is now pending FreeBSD build investigation in #475.

[Bodigrim]

Once GHC 9.6 is released, GHC 9.4 will become the oldest bootstrap compiler. So we are free to merge this right after we cut a release for GHC 9.6, which is fairly soon I hope.

[Ericson2314]

What's the issue with GHC before 9.4? Hadrian is allowed to depend on things on Hackage.

[Bodigrim]

This is ready for review now. Both haskell/primitive#359 and haskell/bytestring#410 have been merged.

[RyanGlScott]

Another breaking change that this PR brings about (aside from the discussion about instances in #474 (comment)) is that you will no longer be able to import Array like so:

import Data.Text.Array (Array (..))

The aeson library actually does this—see this code. As a result, aeson no longer builds with the latest text master branch, which is slated to be released with GHC 9.8. (See this failing GHC 9.8 head.hackage CI job.) I only bring this up because the text version is still 2.0.2 (the same version released with GHC 9.6), and it took me a while to figure out what had changed.