Gracefully handle circular dependencies in watch mode#373
Merged
fdserr merged 1 commit intolambdaisland:mainfrom Jan 23, 2023
Merged
Gracefully handle circular dependencies in watch mode#373fdserr merged 1 commit intolambdaisland:mainfrom
fdserr merged 1 commit intolambdaisland:mainfrom
Conversation
assoc undo tweak
Codecov ReportBase: 75.47% // Head: 75.26% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
- Coverage 75.47% 75.26% -0.22%
==========================================
Files 51 51
Lines 2732 2745 +13
Branches 255 257 +2
==========================================
+ Hits 2062 2066 +4
- Misses 510 517 +7
- Partials 160 162 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
|
When I test against your reproduction (thanks again for that), it works when I start watch mode without a circular dependency add one, and then remove one, but if I start it with a circular dependency and then remove it, I get this: |
Contributor
Author
|
Couldn't reproduce, I tried removing the cycle in either file and both seem to have similar output: |
Member
|
Hmm, I'm testing on Ubuntu Linux 22.04, Clojure 1.11.1, and Java 13. I can try poking around to see what might be interfering with loading the test namespace. |
Contributor
|
Works as expected: watch keeps running when cycling on/off a circular dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #372
This keeps watch mode active even in the presence of circular dependencies. Basically, a tool.namespace cyclic deps error is now treated as a normal compilation error from the user's perspective.
I tested this successfully against the minimal reproduction: frenchy64/kaocha-circular-watch-reprod#1
I tried this this on a larger project and first impressions are positive. I let the tests run through once, then intentionally added a circular dep to one of the core namespaces (depended on by dozens of files), then removed it. It behaved as expected and the process was not killed.
Full transcript