Support explicit, terminated chain sequences.#176
Support explicit, terminated chain sequences.#176jdalton merged 1 commit intolodash:masterfrom m-orchard:add-chain-support
Conversation
|
|
|
Whoa! So awesome! 🎉 |
|
I'd be happy to see this merged as is, we could start using the plugin but we would enforce no unterminated or implicit chaining. Does it need rebasing? Looks like it picked up unintentional commits. |
|
Ah yes, will rebase! |
|
Rebased |
|
@jdalton any chance of getting this merged or reviewed soon? |
|
Hi @lukeapage! I have my head down with the WIP esm loader at the moment. |
|
Any update on this? |
|
Bump on this, would be amazeballs to get out! ⚡️ |
|
what about now? 😁 |
|
@jdalton I've pushed an up-to-date version of this. I noticed you've updated your code style - I tried to bring my changes inline with that, so let me know if there's anything I've missed! |
|
@mickylad Thank you! Yeah, my code style tends to change based on the last project I worked on. There is now a clash of styles I'll be dealing with 😋 |
|
🎉 🎉 🎉 |
|
I know the feeling! Thanks! :) |
|
Can we get a release? |
|
are we gonna get a release in 2018? @mickylad @jdalton @anyone-who-cares |
|
I care.. am waiting to use it, though if I get the time I will just publish it privately, so this is an annoyance but not a blocker. |
|
@lukeapage @mickylad @laander @rkrueger11 PR was reverted :( |
|
Even thought it was ultimately reverted I'm very thankful to @mickylad for putting the time into this and its follow-up PR! Related to #210 (comment). |
9 participants
This does some work towards #92 - I've not had time yet to figure out if or how unterminated chains might be handled, as well as imlpicit chains.
Would be good to know if this is something you'd be willing to merge, I know you said you would accept a PR on #92 but obviously this doesn't cover all cases, at least yet.
If you do have thoughts on how unterminated and implicit chains could be handled, I'd be glad to hear them and see if I can make any more progress.