Refactor: trim unnecessary DLL deps from COMMON_LINK_LIBRARIES

[benhillis]

This change limits executables to only link against libraries that they actually need to. This reduces the memory overhead and launch time of each process that was previously loading unneeded dlls. To accomplish this some utilities were moved to separate .cpp files so separate .obj files are created, then the linker can do that right things.

• Split MSI/Wintrust install functions from wslutil.cpp into install.cpp
• Remove MI.lib, wsldeps.lib, msi.lib, Wintrust.lib from COMMON_LINK_LIBRARIES
• Add per-target INSTALL_LINK_LIBRARIES and SERVICE_LINK_LIBRARIES
• Result: wslhost, wslrelay, wslcsdk no longer import msi/wintrust; wslhost also loses MI/wsldeps; wslservice loses msi/wintrust in debug builds

[Copilot]

Pull request overview

This PR refactors Windows build/link configuration to reduce unnecessary DLL imports by moving MSI/Wintrust-dependent helpers into a separate translation unit and splitting common link dependencies into per-scenario link groups.

Changes:

• Split MSI/Wintrust-related install/update utilities out of wslutil.cpp into a new install.cpp TU to enable dead-stripping at link time.
• Refactor global link lists: remove MSI/Wintrust/MI/wsldeps from COMMON_LINK_LIBRARIES and introduce ${INSTALL_LINK_LIBRARIES} / ${SERVICE_LINK_LIBRARIES}.
• Update multiple Windows targets (and tests) to link the narrower per-scenario library sets.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
CMakeLists.txt	Splits global link library lists into common vs install vs service groups.
src/windows/common/CMakeLists.txt	Adds new install.cpp source to the common static library.
src/windows/common/wslutil.cpp	Removes MSI/Wintrust-dependent implementations after they’re moved out.
src/windows/common/install.cpp	New file containing MSI/Wintrust install/update/signature helpers.
src/windows/service/exe/CMakeLists.txt	Links service executable with ${INSTALL_LINK_LIBRARIES} and ${SERVICE_LINK_LIBRARIES}.
src/windows/wsl/CMakeLists.txt	Links wsl.exe with ${INSTALL_LINK_LIBRARIES} (needed for MSI-forward/update paths).
src/windows/wslg/CMakeLists.txt	Links wslg with ${INSTALL_LINK_LIBRARIES}.
src/windows/wslinstall/CMakeLists.txt	Replaces direct Msi.lib link with ${INSTALL_LINK_LIBRARIES}.
src/windows/wslinstaller/exe/CMakeLists.txt	Links wslinstaller with ${INSTALL_LINK_LIBRARIES}.
test/windows/CMakeLists.txt	Links test DLL with ${INSTALL_LINK_LIBRARIES} and ${SERVICE_LINK_LIBRARIES}.

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

This PR refactors the build/link setup so executables only link (and therefore load) the DLLs they actually require, primarily by extracting MSI/Wintrust-dependent helpers out of wslutil.cpp into a separate compilation unit and splitting the global link-library list into smaller per-purpose sets.

Changes:

• Split MSI/Wintrust install helpers from wslutil.cpp into new install.cpp to allow the linker to omit those objects (and their DLL imports) for unrelated targets.
• Refactor top-level COMMON_LINK_LIBRARIES into COMMON_LINK_LIBRARIES, MSI_LINK_LIBRARIES, HCS_LINK_LIBRARIES, and SERVICE_LINK_LIBRARIES, then update affected targets to link the narrower sets.
• Add delay-loading for msi.dll and wintrust.dll in wsl.exe and wslg.exe to reduce startup cost when install/update paths aren’t used.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/windows/CMakeLists.txt	Adds per-purpose link library sets to keep test binary linking consistent after COMMON is trimmed.
src/windows/wslinstaller/exe/CMakeLists.txt	Links MSI-related libs explicitly after removal from common set.
src/windows/wslinstall/CMakeLists.txt	Replaces direct Msi.lib with ${MSI_LINK_LIBRARIES}.
src/windows/wslg/CMakeLists.txt	Adds MSI libs + delayimp.lib and delay-load flags for msi.dll/wintrust.dll.
src/windows/wsl/CMakeLists.txt	Same as wslg: explicit MSI libs + delay-load configuration.
src/windows/service/exe/CMakeLists.txt	Switches from broad/common deps to ${HCS_LINK_LIBRARIES} / ${SERVICE_LINK_LIBRARIES} (+ MSI list).
src/windows/common/wslutil.cpp	Removes MSI/Wintrust install helper implementations (moved to install.cpp).
src/windows/common/install.cpp	New compilation unit containing MSI/Wintrust install helpers previously in wslutil.cpp.
src/windows/common/CMakeLists.txt	Adds install.cpp to the common static library sources.
CMakeLists.txt	Splits COMMON_LINK_LIBRARIES into smaller link-library sets for tighter per-target linkage.

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

This PR refactors Windows target link dependencies so each executable/DLL only links the import libraries it actually needs, reducing unnecessary DLL loads (startup/memory overhead). It also moves MSI/Wintrust-related helpers out of wslutil.cpp into a separate translation unit so the linker can avoid pulling those dependencies into unrelated binaries.

Changes:

• Split MSI/Wintrust install + signature-validation helpers from wslutil.cpp into new src/windows/common/install.cpp.
• Replace monolithic COMMON_LINK_LIBRARIES usage by introducing MSI_LINK_LIBRARIES, HCS_LINK_LIBRARIES, and SERVICE_LINK_LIBRARIES, then applying them per-target.
• Add delay-load configuration for msi.dll and wintrust.dll to wsl.exe and wslg.exe.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
CMakeLists.txt	Splits common link dependencies into smaller per-feature groups (MSI/HCS/Service).
src/windows/common/CMakeLists.txt	Adds new install.cpp to the common static library sources.
src/windows/common/wslutil.cpp	Removes MSI/Wintrust install/signing helper implementations (moved to install.cpp).
src/windows/common/install.cpp	New implementation file containing MSI/Wintrust helpers previously in wslutil.cpp.
src/windows/service/exe/CMakeLists.txt	Updates wslservice to link against the new grouped link libraries.
src/windows/wsl/CMakeLists.txt	Adds MSI link group + delay-load flags and delayimp.lib.
src/windows/wslg/CMakeLists.txt	Adds MSI link group + delay-load flags and delayimp.lib.
src/windows/wslinstall/CMakeLists.txt	Replaces direct Msi.lib usage with ${MSI_LINK_LIBRARIES}.
src/windows/wslinstaller/exe/CMakeLists.txt	Adds ${MSI_LINK_LIBRARIES} to the installer executable.
test/windows/CMakeLists.txt	Updates test DLL linking to include the new grouped link libraries.

---

You can also share your feedback on Copilot code review. Take the survey.