All references are not listed when using ms language server

[DonJayamanne]

@jahan01 commented on Wed Jun 05 2019

Environment data

• VS Code version: latest
• Extension version (available under the Extensions sidebar): 2019.5.18426
• OS and version: Mac Os
• Python version (& distribution if applicable, e.g. Anaconda): 3.6 (Anaconda)
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
• Language Server (more info #3977): Language Server

constants.py

VARIABLE1 = 'afad'
VARIABLE2 = 'dcef'

use.py

from vscode_test.constants import *
from vscode_test import constants

print(VARIABLE1)
print(constants.VARIABLE2)

print(VARIABLE2)
print(constants.VARIABLE1)

Expected behaviour

All usages of the symbol to be listed under references when Right click -> Find All References on VARIABLE1 in constants.py

Actual behaviour

Doesn't list all usages when ms language server is used.
Usage of print(constants.VARIABLE1) in use.py isnt listed.

Looks like if symbol is imported directly, the reference is listed. If the symbol referenced via modules it isn't listed.

This issue seems to be recurring - why not have some tests for this ?

When Jedi is enabled it works as expected.

[MikhailArkhipov]

Slightly simplified

from .constants import *
import constants

print(VARIABLE1)
print(constants.VARIABLE2)

print(VARIABLE2)
print(constants.VARIABLE1)

[MikhailArkhipov]

So the problem is that since expression is not assigned (i.s. as opposed to x = func(a), none of the parts participate in analysis downstream, the arguments are not evaluated and hence reference is not added. Reference to VARIABLE* is added by the linter when it is looking up defined/undefined variables.

Also relates to #533. Currently print comes from scraper as a function that does not have arguments hence constants.VARIABLE1 is not evaluated. One option without #533 is to evaluate arguments regardless.

[MikhailArkhipov]

Adding cost to eval arguments in all cases.