Skip to content

optimize_CI#1314

Merged
you-n-g merged 1 commit intomicrosoft:mainfrom
SunsetWolf:optimize_CI
Oct 20, 2022
Merged

optimize_CI#1314
you-n-g merged 1 commit intomicrosoft:mainfrom
SunsetWolf:optimize_CI

Conversation

@SunsetWolf
Copy link
Copy Markdown
Collaborator

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@ChiahungTai
Copy link
Copy Markdown
Collaborator

yes.....
The CI is very annoying....
Make people away from contribution.
The furstated part

def get_dataset_config(
dataset_class=DATASET_ALPHA158_CLASS,
train=("2008-01-01", "2014-12-31"),
train=("2013-01-01", "2014-12-31"),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@you-n-g you-n-g mentioned this pull request Oct 14, 2022
5 tasks
@SunsetWolf SunsetWolf marked this pull request as ready for review October 19, 2022 16:45
@you-n-g you-n-g merged commit 1861c8e into microsoft:main Oct 20, 2022
@you-n-g
Copy link
Copy Markdown
Contributor

you-n-g commented Oct 20, 2022

@SunsetWolf
It looks great now!
Thanks!

@ChiahungTai The CI is fixed now...

@ChiahungTai
Copy link
Copy Markdown
Collaborator

@SunsetWolf It looks great now! Thanks!

@ChiahungTai The CI is fixed now...

Thanks for the info. :)

@you-n-g you-n-g added bug Something isn't working enhancement New feature or request labels Dec 9, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants