Merged
Conversation
eamodio
force-pushed
the
eamodio/build
branch
from
503e961 to
85effa0
Compare
Splits the webviews out of the initial bundle to optimize loading perf Replaces moment with day.js to reduce size & improve perf Updates many package dependencies
eamodio
force-pushed
the
eamodio/build
branch
from
85effa0 to
abba941
Compare
RMacfarlane
reviewed
Feb 22, 2021
src/api/api.d.ts
Outdated
| Tag | ||
| } | ||
| export { RefType } from './api1'; | ||
| // export const enum RefType { |
src/api/api.d.ts
Outdated
| PatchDoesNotApply = 'PatchDoesNotApply' | ||
| } | ||
| export { GitErrorCodes } from './api1'; | ||
| // export const enum GitErrorCodes { |
src/authentication/githubServer.ts
Outdated
| return [ | ||
| uri, | ||
| { | ||
| hostname: (await HostHelper.getApiHost(hostUri)).authority, |
|
|
||
| private _iter: IKeyIterator; | ||
| private _root: TernarySearchTreeNode<E> | undefined; | ||
| static forPaths<E>(): TernarySearchTree<string, E> { |
Contributor
There was a problem hiding this comment.
several unused things here - forPaths, forStrings, forConfigKeys. should we wait to introduce these utils until they're actually needed?
Contributor
Author
There was a problem hiding this comment.
Up to you -- I just grabbed the entire thing from the vscode repo (to maybe easier to keep it "in sync")
Contributor
There was a problem hiding this comment.
that's a fair point, let's leave it as is
| </head> | ||
| <body> | ||
| <div id="app"></div> | ||
| <script nonce="${nonce}" src="${this._webview!.asWebviewUri(uri).toString()}"></script> |
Contributor
There was a problem hiding this comment.
this also works in the webworker case?
| import { sep } from 'path'; | ||
| import moment = require('moment'); | ||
| import { Disposable, Event, Uri } from 'vscode'; | ||
| import dayjs from 'dayjs'; |
src/github/githubRepository.ts
Outdated
| } | ||
|
|
||
| return new PullRequestModel(this._telemetry, this, this.remote, convertRESTPullRequestToRawPullRequest(pullRequest, this)); | ||
| return new PullRequestModel(this._telemetry, this, this.remote, convertRESTPullRequestToRawPullRequest(pullRequest as any, this)); |
Contributor
There was a problem hiding this comment.
I think this cast to any is unneeded
Contributor
Author
There was a problem hiding this comment.
Yup, not needed anymore
| if (reviewManager) { | ||
| return pushAndCreatePR(currentIssue.manager, reviewManager, this._stateManager); | ||
| } | ||
| break; |
| repositories_url: { default: 'https://api.github.com/teams/1/repos' }, | ||
| parent: { default: { test: 'test' } }, | ||
| html_url: { default: 'https://api.github.com/teams/1' } | ||
| // parent: { default: { test: 'test' } }, |
src/extension.ts
Outdated
| } | ||
|
|
||
| export async function activate(context: vscode.ExtensionContext): Promise<GitApiImpl> { | ||
| extensionId = 'github.vscode-pull-request-github'; |
Contributor
There was a problem hiding this comment.
there is actually EXTENSION_ID used below which should capture this and is changed in the build, it could just be marked as not const to be reused here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slims the initial bundle size
Splits the webviews out of the initial bundle to optimize loading perf
Replaces TSLint with ESLint
Replaces moment with day.js to reduce size & improve perf
Updates many package dependencies
Adds esbuild option (on by default)