Enable string type for numbers in launch attributes#134
Merged
paulacamargo25 merged 2 commits intomicrosoft:mainfrom Nov 20, 2023
Merged
Conversation
| } else if (configuration.port !== undefined) { | ||
| traceLog(`Connecting to DAP Server at: ${configuration.host ?? '127.0.0.1'}:${configuration.port}`); | ||
| return new DebugAdapterServer(configuration.port, configuration.host ?? '127.0.0.1'); | ||
| return new DebugAdapterServer(Number(configuration.port), configuration.host ?? '127.0.0.1'); |
Member
There was a problem hiding this comment.
should there be some error handling when this doesn't cast properly?
Contributor
Author
There was a problem hiding this comment.
The adapter handle the error if the data is not right
TylerLeonhardt
previously approved these changes
Nov 9, 2023
paulacamargo25
changed the title
paulacamargo25
changed the title
paulacamargo25
changed the title
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
TylerLeonhardt
approved these changes
Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed: #115