Inside of a notebook, magic cells should not cause an error in pylance

[rchiodo]

Add a cell like so:

%connect_info

That is a valid magic command. It would be nice if Pylance would recognize these.

[jakebailey]

I assume this would be blocked by "real" notebook cell support over the LSP, since we don't want to allow this in regular Python code (or maybe we special case the vscode-notebook schema sent for the fake concat docs). Right now, we aren't notebook aware at all (and don't know how to parse these).

[rchiodo]

Well actually we want them in regular python code if using the interactive window too (but that seems less important).

I was hoping we could just special case these somehow. Either in the concatenation layer or in pylance itself based on some way of detecting notebook cells.

[rchiodo]

Without having to go full blown notebook in the LSP

[jakebailey]

This is silly, but one way to hack it would be to replace every line that starts with % with an equivalent number of spaces before sending it.

[jakebailey]

Or, replace % with #.

[jakebailey]

Unless the line is a continuation of the % operator. (I don't know what the syntax of magic cells are when distinguishing them from regular % uses.)

[rchiodo]

Well ideally autocomplete would work. % is actually the prefix for cell magics. There's like 100 of them that are allowed.

[jakebailey]

Not having a syntax error is one thing, trying to autocomplete them is another. Does the notebook code already discard the syntax error or was that the main thing you were looking for?

[rchiodo]

No it doesn't discard the syntax error at the moment. The red squiggle comes up. I agree the first step would be to not generate the squiggle.

Second step is autocomplete.

[rchiodo]

Here's another example of something similar:
microsoft/vscode-jupyter#4554

Maybe there's something we can do for notebooks to remove diagnostics that are not relevant for a cell. I was thinking do the removal at the concat level (as it knows about notebooks). Similar to what @jakebailey suggested above about adding extra spaces

[jakebailey]

Wild, I didn't know ! was a thing. Is there some reference somewhere that lists them so we don't forget any?

[rchiodo]

I haven't found an easy reference, but if you read the docs here it ends up listing all the goofy things you can do with jupyter:
https://ipython.readthedocs.io/en/stable/interactive/reference.html

Well at least in an ipython kernel.

[jakebailey]

Wow, that's a lot. 🙁

[ScottNotFound]

Apparently in regular python files you do something like

#%%
import os
print(os.getcwd())
#! %cd ..
print(os.getcwd())

You get the magic executed and avoid the linting errors. Related: microsoft/vscode-jupyter#3263
I tried to use this as a workaround, but in a notebook this doesn't work. The magic won't execute when it is commented. Perhaps that's something for the jupyter extension to fix. I don't know if it would be best for the jupyter extension to just eat these or have them handled specifically by pylance, or any other language server for that matter. I guess magic autocompletion would be neat, but I don't really see more than a few line magics in notebooks anyway.

[rchiodo]

I think we were going to handle these in the python extension (where we parse the diagnostics as they come back) and skip ones for magics.