Creating environment using conda fails

[karrtikr]

Using pre-release build:

Running Conda Env creation script:  [
  'python.exe',
  'c:\\Users\\karraj\\.vscode-insiders\\extensions\\ms-python.python-2022.17.12981938\\pythonFiles\\create_conda.py',
  '--git-ignore',
  '--install',
  '--python',
  '3.10'
]
Running: C:\Users\karraj\AppData\Local\Programs\Python\Python37\python.exe -m conda create --yes --prefix .conda python=3.10
C:\Users\karraj\AppData\Local\Programs\Python\Python37\python.exe: No module named conda
Traceback (most recent call last):
File "c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2022.17.12981938\pythonFiles\create_conda.py", line 61, in run_process
subprocess.run(args, cwd=os.getcwd(), check=True)
File "C:\Users\karraj\AppData\Local\Programs\Python\Python37\lib\subprocess.py", line 512, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['C:\\Users\\karraj\\AppData\\Local\\Programs\\Python\\Python37\\python.exe', '-m', 'conda', 'create', '--yes', '--prefix', '.conda', 'python=3.10']' returned non-zero exit status 1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2022.17.12981938\pythonFiles\create_conda.py", line 131, in <module>
main(sys.argv[1:])
File "c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2022.17.12981938\pythonFiles\create_conda.py", line 119, in main
"CREATE_CONDA.ENV_FAILED_CREATION",
File "c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2022.17.12981938\pythonFiles\create_conda.py", line 63, in run_process
raise VenvError(error_message)
__main__.VenvError: CREATE_CONDA.ENV_FAILED_CREATION

Interpreter being used to launch conda is not the base conda environment. Also, I expected an error prompt if creating environment fails.

[karrtikr]

conda.command is not guranteed to contain the full path to conda. In most cases it is just "conda".

vscode-python/src/client/pythonEnvironments/creation/provider/condaCreationProvider.ts

Lines 136 to 155 in ae63943

	function getExecutableCommand(condaPath: string): string {
	if (getOSType() === OSType.Windows) {
	// Both Miniconda3 and Anaconda3 have the following structure:
	// Miniconda3 (or Anaconda3)
	// |- condabin
	// | |- conda.bat <--- this actually points to python.exe below,
	// | after adding few paths to PATH.
	// |- Scripts
	// | |- conda.exe <--- this is the path we get as condaPath,
	// | which is really a stub for `python.exe -m conda`.
	// |- python.exe <--- this is the python that we want.
	return path.join(path.dirname(path.dirname(condaPath)), 'python.exe');
	}
	// On non-windows machines:
	// miniconda (or miniforge or anaconda3)
	// |- bin
	// |- conda <--- this is the path we get as condaPath.
	// |- python <--- this is the python that we want.
	return path.join(path.dirname(condaPath), 'python');
	}

Should probably look for base conda environment to get the python instead.

[karthiknadig]

There are two problems here:

1. The error callback is not getting called when the process exits with a non-zero error code
2. The path to conda base python should be calculated using base as @karrtikr suggested.